Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #14559

Re: review for pipenv/2022.10.12-1

Path csiph.com!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From Jeroen Ploemen <jcfp@debian.org>
Newsgroups linux.debian.maint.python
Subject Re: review for pipenv/2022.10.12-1
Date Thu, 27 Oct 2022 19:20:01 +0200
Message-ID <FleHT-h7II-1@gated-at.bofh.it> (permalink)
References <FjqDv-fZP8-1@gated-at.bofh.it> <FkPTb-gRY4-5@gated-at.bofh.it>
X-Original-To Ileana Dumitrescu <ileanadumitrescu95@gmail.com>
X-Mailbox-Line From debian-python-request@lists.debian.org Thu Oct 27 17:18:03 2022
Old-Return-Path <jcfp@debian.org>
X-Amavis-Spam-Status No, score=-113.664 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FOURLA=0.1, GMAIL=1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no
X-Mailer Claws Mail 4.1.0 (GTK 3.24.20; x86_64-pc-linux-gnu)
MIME-Version 1.0
Content-Type multipart/signed; boundary="Sig_/jg+gkH0ZmP/Ga0fW6+VyYd8"; protocol="application/pgp-signature"; micalg=pgp-sha512
X-Debian-User jcfp
X-Mailing-List <debian-python@lists.debian.org> archive/latest/20411
List-ID <debian-python.lists.debian.org>
List-URL <https://lists.debian.org/debian-python/>
List-Archive https://lists.debian.org/msgid-search/20221027191728.098728e4@debian.org
Approved robomod@news.nic.it
Lines 68
Organization linux.* mail to news gateway
Sender robomod@news.nic.it
X-Original-Cc debian-python <debian-python@lists.debian.org>
X-Original-Date Thu, 27 Oct 2022 19:17:28 +0200
X-Original-Message-ID <20221027191728.098728e4@debian.org>
X-Original-References <20221022193344.418fa99e@debian.org> <CAOJuXaPGVe-t+59U-6T8JRbGmriZsrXog=ku=0UFBmXv4gYvWQ@mail.gmail.com>
Xref csiph.com linux.debian.maint.python:14559

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, 26 Oct 2022 17:29:59 +0300
Ileana Dumitrescu <ileanadumitrescu95@gmail.com> wrote:

> Thank you for the feedback! I made changes as you suggested. There
> is a new upstream version that I also included in the new package.

Great! The copyright stuff is a chore on packages like this, so
thanks alot for seeing that through.

> Reading debian package policy I noticed that removing files from a
> tarball for a repack (as Bastian suggested in bug #1019714) should
> require a +ds suffix, so I packaged the new version with
> 2022.10.25+ds-1. Please let me know if I did this incorrectly or if
> this should not be done for this package.

Indeed, a repacksuffix is used to indicate changes were made to an
upstream release so that's perfectly fine this way. Typically, +dfsg
is used to signal the source was repacked for DFSG compliance reasons
and +ds when repacking for some other reason.

I did just notice the upstream release contains several other files
worth considering for removal: a bunch of windows executables [1].
 
> > + E: pipenv: python-traceback-in-manpage is a false positive,  
>     please override.
> 
> This did not show up in lintian with the new upstream version.

It seems they revamped the manpage, although the new one also earns a
lintian hit [1], this time about a bad (missing?) 'whatis' entry.

Lintian seems to think the source for some html file is missing, but
at first glance that hit may well be a false positive triggered by
some bits of javascript.


Unrelated to any of the above, I pushed some minor changes and
enabled the CI on salsa.


[1]https://salsa.debian.org/python-team/packages/pipenv/-/jobs/3434663

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

review for pipenv/2022.10.12-1 Jeroen Ploemen <jcfp@debian.org> - 2022-10-22 19:40 +0200
  Re: review for pipenv/2022.10.12-1 Ileana Dumitrescu <ileanadumitrescu95@gmail.com> - 2022-10-26 16:50 +0200
    Re: review for pipenv/2022.10.12-1 Jeroen Ploemen <jcfp@debian.org> - 2022-10-27 19:20 +0200
      Re: review for pipenv/2022.10.12-1 Ileana Dumitrescu <ileanadumitrescu95@gmail.com> - 2022-10-28 16:10 +0200
        Re: review for pipenv/2022.10.12-1 Jeroen Ploemen <jcfp@debian.org> - 2022-10-29 09:30 +0200
          Re: review for pipenv/2022.10.12-1 Ileana Dumitrescu <ileanadumitrescu95@gmail.com> - 2022-10-31 15:50 +0100
  Re: review for pipenv/2022.10.12-1 Bastian Venthur <venthur@debian.org> - 2022-10-28 18:20 +0200

csiph-web