Groups > linux.debian.maint.python > #14552

review for pipenv/2022.10.12-1

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Jeroen Ploemen <jcfp@debian.org>
Newsgroups	linux.debian.maint.python
Subject	review for pipenv/2022.10.12-1
Date	Sat, 22 Oct 2022 19:40:01 +0200
Message-ID	<FjqDv-fZP8-1@gated-at.bofh.it> (permalink)
X-Mailbox-Line	From debian-python-request@lists.debian.org Sat Oct 22 17:34:05 2022
Old-Return-Path	<jcfp@debian.org>
X-Amavis-Spam-Status	No, score=-114.764 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no
X-Mailer	Claws Mail 4.1.0 (GTK 3.24.20; x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	multipart/signed; boundary="Sig_/11aAQSg3_LyvkMx8X1Dx80f"; protocol="application/pgp-signature"; micalg=pgp-sha512
X-Debian-User	jcfp
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/20403
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/20221022193344.418fa99e@debian.org
Approved	robomod@news.nic.it
Lines	57
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Cc	debian-python <debian-python@lists.debian.org>
X-Original-Date	Sat, 22 Oct 2022 19:33:44 +0200
X-Original-Message-ID	<20221022193344.418fa99e@debian.org>
Xref	csiph.com linux.debian.maint.python:14552

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

hi Ileana,

I took a look at the package update you prepared and put up for
sponsorship in the Python team:

* leftover boilerplate comments and examples remain throughout the
  packaging (control, rules, watch), please remove when unused.
* changelog: isn't #941447 also fixed by the new release? See
  upstream's comment on https://github.com/pypa/pipenv/issues/4144
* copyright:
  + packaging year bumped for venthur@debian.org but his last
    involvement actually does appear to have been in 2018; you
    probably want to add yourself instead with a 2022 entry?
  + `grep -irn --exclude-dir=debian 'copyr.*\(19\|20\)[0-9]\{2\}' *`
    turns up numerous copyright holders that are missing from
    d/copyright.
* watch: filenamemangle introduces literal "<project>" string into
  the filename.
* lintian:
  + numerous hits for 'extra-license-file' and
    'package-contains-documentation-outside-usr-share-doc', triggered
    by license and readme files inside vendored libs; these files
    could easily be removed during build.
  + E: pipenv: python-traceback-in-manpage is a false positive,
    please override.


PS: I'm kind of surprised a package with this amount of vendoring
managed to survive the ftp masters' review. Apparently, sometimes
miracles do happen.

Back to linux.debian.maint.python | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

review for pipenv/2022.10.12-1 Jeroen Ploemen <jcfp@debian.org> - 2022-10-22 19:40 +0200
  Re: review for pipenv/2022.10.12-1 Ileana Dumitrescu <ileanadumitrescu95@gmail.com> - 2022-10-26 16:50 +0200
    Re: review for pipenv/2022.10.12-1 Jeroen Ploemen <jcfp@debian.org> - 2022-10-27 19:20 +0200
      Re: review for pipenv/2022.10.12-1 Ileana Dumitrescu <ileanadumitrescu95@gmail.com> - 2022-10-28 16:10 +0200
        Re: review for pipenv/2022.10.12-1 Jeroen Ploemen <jcfp@debian.org> - 2022-10-29 09:30 +0200
          Re: review for pipenv/2022.10.12-1 Ileana Dumitrescu <ileanadumitrescu95@gmail.com> - 2022-10-31 15:50 +0100
  Re: review for pipenv/2022.10.12-1 Bastian Venthur <venthur@debian.org> - 2022-10-28 18:20 +0200

csiph-web