Groups > linux.debian.maint.python > #14767

Re: review for pytest-fail-slow/0.3.0-1

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Ileana Dumitrescu <ileanadumitrescu95@gmail.com>
Newsgroups	linux.debian.maint.python
Subject	Re: review for pytest-fail-slow/0.3.0-1
Date	Wed, 21 Dec 2022 18:10:01 +0100
Message-ID	<FFaLn-cdUo-3@gated-at.bofh.it> (permalink)
References	<FCzwB-aBJg-1@gated-at.bofh.it>
X-Mailbox-Line	From debian-python-request@lists.debian.org Wed Dec 21 17:01:05 2022
Old-Return-Path	<ileanadumitrescu95@gmail.com>
X-Amavis-Spam-Status	No, score=-6.95 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, PGPSIGNATURE=-5, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham autolearn_force=no
X-Policyd-Weight	using cached result; rate: -5.5
X-Gm-Message-State	AFqh2kqKZgiGWxxAsCxQqj5Iau0FPHuL648IwDlozUQbx4iGgJ1z78G8 M7bJfHn7KzOHVBC9S1vScf8=
X-Google-SMTP-Source	AMrXdXumbnJg6EzPwIfj7Ol+Avj4392ZvCdoNgn3E8KU15bxTHocqY9GA+8BJW91WMnr8ZWxjO0STA==
X-Received	by 2002:a05:600c:4a86:b0:3cf:a08f:10a5 with SMTP id b6-20020a05600c4a8600b003cfa08f10a5mr2154216wmp.31.1671642042261; Wed, 21 Dec 2022 09:00:42 -0800 (PST)
MIME-Version	1.0
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1
Content-Language	en-US
Content-Type	multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------E7scRV5FmFpZt06Fs52l57dT"
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/20635
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/55969d52-f38f-096d-94f7-90dd48dd35bf@gmail.com
Approved	robomod@news.nic.it
Lines	146
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Cc	debian-python@lists.debian.org
X-Original-Date	Wed, 21 Dec 2022 19:00:37 +0200
X-Original-Message-ID	<55969d52-f38f-096d-94f7-90dd48dd35bf@gmail.com>
X-Original-References	<20221214135120.3ea97dce@debian.org>
Xref	csiph.com linux.debian.maint.python:14767

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

> Some repo issues:
> * It appears tags were not pushed, as there's no tags at all in the
>    repo - not even for the imported upstream release - although the
>    typical gbp workflow would handle that.

That is done now.

> * The upstream tarball produced by uscan differs from the
>    pristine-tar data. Are you making use of the standard tools for
>    importing new releases, e.g. 'gbp import-orig --pristine-tar
>    --uscan' or similar?

This was strange but I found the reason. The upstream repo in github had 
two .tar.gz files that were slightly different, so I updated the 
branches to be consistent with uscan. But I am using the standard tools.

> Then for the packaging itself (which is in pretty good shape):
> * changelog: please leave the release at UNRELEASED, cf. team policy.
> * control:
>    + the binary pkg for a pytest plugin is commonly named
>      python3-pytest-<name-of-plugin>;
>    + short description: Pytest plugin to [current description]?
> * upstream/metadata missing.
> * no autopkgtest? Should be a trivial yet *very* useful addition,
>    providing early warning for things like compatibility issues with
>    newer pytest releases before packages using the plugin start seeing
>    failures.

All are updated as asked, and I created an autopkgtest.

Thank you for the feedback! Is there a check list that you follow when
reviewing these packages? That can help with future uploads.

-- 
Ileana Dumitrescu

GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

review for pytest-fail-slow/0.3.0-1 Jeroen Ploemen <jcfp@debian.org> - 2022-12-14 14:00 +0100
  Re: review for pytest-fail-slow/0.3.0-1 Ileana Dumitrescu <ileanadumitrescu95@gmail.com> - 2022-12-21 18:10 +0100

csiph-web