Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #14767

Re: review for pytest-fail-slow/0.3.0-1

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

> Some repo issues:
> * It appears tags were not pushed, as there's no tags at all in the
>    repo - not even for the imported upstream release - although the
>    typical gbp workflow would handle that.

That is done now.

> * The upstream tarball produced by uscan differs from the
>    pristine-tar data. Are you making use of the standard tools for
>    importing new releases, e.g. 'gbp import-orig --pristine-tar
>    --uscan' or similar?

This was strange but I found the reason. The upstream repo in github had 
two .tar.gz files that were slightly different, so I updated the 
branches to be consistent with uscan. But I am using the standard tools.

> Then for the packaging itself (which is in pretty good shape):
> * changelog: please leave the release at UNRELEASED, cf. team policy.
> * control:
>    + the binary pkg for a pytest plugin is commonly named
>      python3-pytest-<name-of-plugin>;
>    + short description: Pytest plugin to [current description]?
> * upstream/metadata missing.
> * no autopkgtest? Should be a trivial yet *very* useful addition,
>    providing early warning for things like compatibility issues with
>    newer pytest releases before packages using the plugin start seeing
>    failures.

All are updated as asked, and I created an autopkgtest.

Thank you for the feedback! Is there a check list that you follow when
reviewing these packages? That can help with future uploads.

-- 
Ileana Dumitrescu

GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

review for pytest-fail-slow/0.3.0-1 Jeroen Ploemen <jcfp@debian.org> - 2022-12-14 14:00 +0100
  Re: review for pytest-fail-slow/0.3.0-1 Ileana Dumitrescu <ileanadumitrescu95@gmail.com> - 2022-12-21 18:10 +0100

csiph-web