Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #14727 > unrolled thread

review for pytest-fail-slow/0.3.0-1

Back to article view | Back to linux.debian.maint.python

Contents

  review for pytest-fail-slow/0.3.0-1 Jeroen Ploemen <jcfp@debian.org> - 2022-12-14 14:00 +0100
    Re: review for pytest-fail-slow/0.3.0-1 Ileana Dumitrescu <ileanadumitrescu95@gmail.com> - 2022-12-21 18:10 +0100

#14727 — review for pytest-fail-slow/0.3.0-1

[Multipart message — attachments visible in raw view] — view raw

hi Ileana,

I took a look at pytest-fail-slow, up for sponsorship in the Python
team.

Some repo issues:
* It appears tags were not pushed, as there's no tags at all in the
  repo - not even for the imported upstream release - although the
  typical gbp workflow would handle that.

* The upstream tarball produced by uscan differs from the
  pristine-tar data. Are you making use of the standard tools for
  importing new releases, e.g. 'gbp import-orig --pristine-tar
  --uscan' or similar?


Then for the packaging itself (which is in pretty good shape):
* changelog: please leave the release at UNRELEASED, cf. team policy.
* control: 
  + the binary pkg for a pytest plugin is commonly named
    python3-pytest-<name-of-plugin>;
  + short description: Pytest plugin to [current description]?
* upstream/metadata missing.
* no autopkgtest? Should be a trivial yet *very* useful addition,
  providing early warning for things like compatibility issues with
  newer pytest releases before packages using the plugin start seeing
  failures.

[toc] | [next] | [standalone]

#14767

[Multipart message — attachments visible in raw view] — view raw

Hi,

> Some repo issues:
> * It appears tags were not pushed, as there's no tags at all in the
>    repo - not even for the imported upstream release - although the
>    typical gbp workflow would handle that.

That is done now.

> * The upstream tarball produced by uscan differs from the
>    pristine-tar data. Are you making use of the standard tools for
>    importing new releases, e.g. 'gbp import-orig --pristine-tar
>    --uscan' or similar?

This was strange but I found the reason. The upstream repo in github had 
two .tar.gz files that were slightly different, so I updated the 
branches to be consistent with uscan. But I am using the standard tools.

> Then for the packaging itself (which is in pretty good shape):
> * changelog: please leave the release at UNRELEASED, cf. team policy.
> * control:
>    + the binary pkg for a pytest plugin is commonly named
>      python3-pytest-<name-of-plugin>;
>    + short description: Pytest plugin to [current description]?
> * upstream/metadata missing.
> * no autopkgtest? Should be a trivial yet *very* useful addition,
>    providing early warning for things like compatibility issues with
>    newer pytest releases before packages using the plugin start seeing
>    failures.

All are updated as asked, and I created an autopkgtest.

Thank you for the feedback! Is there a check list that you follow when
reviewing these packages? That can help with future uploads.

-- 
Ileana Dumitrescu

GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.maint.python

csiph-web