Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #14496

Re: Bug#1007025: git-multimail 1.6.0 package review

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,
On Thu, Sep 22, 2022 at 02:12:07PM -0400, Antoine Beaupré wrote:
>On 2022-09-22 19:43:24, Jeroen Ploemen wrote:
>> On Thu, 22 Sep 2022 12:35:12 -0400
>> Antoine Beaupré <anarcat@debian.org> wrote:
>>
>>> I think the simplest solution is not to rewrite the launcher, but to
>>> rename it. So in debian/rules, you would simply do:
>>>
>>> override_dh_auto_install:
>>>         dh_auto_install
>>>         mv debian/git-multimail/usr/bin/git_multimail.py
>>> debian/git-multimail/usr/bin/git-multimail
>>
>> Antoine, IIRC the git_multimail.py file upstream installs into
>> /usr/bin is not a launcher but a full copy of the module as installed
>> into /usr/lib/python3. The code in that file auto-detects whether
>> it's run as a program.
>
>Oh. I misunderstood that, sorry.

Sorry, maybe my words misled you also here.

>
>> That resulted in two copies of that sizeable file in the package I
>> reviewed back in June. Hence my suggestion - quoted in an earlier
>> message by Bo - to replace the copy in /usr/bin with a tiny launcher,
>> reducing the installed size of the package by almost half.
>
>Sure, that completely makes sense then, sorry.

Ok, I have re-enabled the launcher and other issues fixed for git-multimail
as your and jcfp's suggestions.

Thanks all and please let me know if any issues.

-- 
Regards,
--
   Bo YU

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

I want to join the DPT vimer <tsu.yubo@gmail.com> - 2022-03-17 09:50 +0100
  Re: I want to join the DPT Sandro Tosi <morph@debian.org> - 2022-03-17 14:20 +0100
    Re: I want to join the DPT vimer <tsu.yubo@gmail.com> - 2022-03-17 15:10 +0100
      Re: I want to join the DPT Sandro Tosi <morph@debian.org> - 2022-03-17 15:30 +0100
    Re: I want to join the DPT Sandro Tosi <morph@debian.org> - 2022-03-17 15:50 +0100
      Re: I want to join the DPT Bo YU <tsu.yubo@gmail.com> - 2022-03-18 10:10 +0100
        Bug#1007025: I want to join the DPT Antoine Beaupré <anarcat@debian.org> - 2022-03-18 14:40 +0100
          Bug#1007025: I want to join the DPT Bo YU <tsu.yubo@gmail.com> - 2022-03-18 15:30 +0100
            Bug#1007025: I want to join the DPT Antoine Beaupré <anarcat@debian.org> - 2022-03-18 18:10 +0100
              Bug#1007025: git-multimail 1.6.0 package review Antoine Beaupré <anarcat@debian.org> - 2022-09-15 18:40 +0200
                Bug#1007025: git-multimail 1.6.0 package review Antoine Beaupré <anarcat@debian.org> - 2022-09-15 18:50 +0200
                Bug#1007025: git-multimail 1.6.0 package review Bo YU <tsu.yubo@gmail.com> - 2022-09-18 05:20 +0200
                Bug#1007025: git-multimail 1.6.0 package review Antoine Beaupré <anarcat@debian.org> - 2022-09-20 17:10 +0200
                Bug#1007025: git-multimail 1.6.0 package review Bo YU <tsu.yubo@gmail.com> - 2022-09-22 11:10 +0200
                Bug#1007025: git-multimail 1.6.0 package review Antoine Beaupré <anarcat@debian.org> - 2022-09-22 18:40 +0200
                Re: Bug#1007025: git-multimail 1.6.0 package review Jeroen Ploemen <jcfp@debian.org> - 2022-09-22 19:50 +0200
                Re: Bug#1007025: git-multimail 1.6.0 package review Antoine Beaupré <anarcat@debian.org> - 2022-09-22 20:20 +0200
                Re: Bug#1007025: git-multimail 1.6.0 package review Bo YU <tsu.yubo@gmail.com> - 2022-09-24 09:40 +0200
                Re: Bug#1007025: git-multimail 1.6.0 package review Bo YU <tsu.yubo@gmail.com> - 2022-09-26 15:10 +0200
    Re: I want to join the DPT vimer <tsu.yubo@gmail.com> - 2022-03-17 16:00 +0100
      Re: I want to join the DPT Stefano Rivera <stefanor@debian.org> - 2022-03-27 00:20 +0100
        Re: I want to join the DPT Bo YU <tsu.yubo@gmail.com> - 2022-03-31 05:30 +0200

csiph-web