Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1118250

Bug#1007025: git-multimail 1.6.0 package review

Cross-posted to 2 groups.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,
On Tue, Sep 20, 2022 at 10:56:05AM -0400, Antoine Beaupré wrote:
>> https://github.com/git-multimail/git-multimail/issues/221#issuecomment-1245009306
>> (To avoid bring noisy for upstream, i just recorded it in a issue)
>
>I don't think pull requests are noisy... you should probably just submit
>this as a PR upstream.

Ok, got it. Will do.
Sometime I mentioned the patch in the issue, the maintainer of upstream will
pick it into if he think that is valuable.
>
>[...]
>
>> nfoview:
>> https://salsa.debian.org/python-team/packages/nfoview/-/blob/debian/master/debian/launcher/nfoview
>>
>> The issue is that I installed git_multimail.py twice in fact it should
>> be under /usr/lib/python3 only as jcfp said. So i remove it in /usr/bin
>> by hand.
>>
>> Now I have removed the launcher for git-multimail and it should work:)
>
>Hm. This is weird. Why would you *not* want git-multimail under
>/usr/bin? I understand the that git_multimail.py *module* should be in
>/usr/lib/, but you should *also* have a launcher in /usr/bin/
>
>I think, therefore, this is incorrect:
>
>+override_dh_python3:
>+       dh_python3
>+       rm -f debian/git-multimail/usr/bin/git_multimail.py
>+
>
>First off, don't use `-f` there: we *do* want to fail if the file
>doesn't exist, so that we can remove the override.
>
yeah, right.

>Second, this looks wrong: `git-multimail` (the launcher) should be the
>thing that's installed under /usr/bin, not `git_multimail.py` (the
>module). If the module ends up in /usr/bin, then it's probably a bug
>upstream that should be filed.
>
>Could you clarify what happens with the package right now?

The issue is that, it really seems like a bug here.

First, I install git-multimail manual:

```
sudo python setup.py install

# log is below
...
creating /usr/local/lib/python3.10/dist-packages/git_multimail-1.5.0-py3.10.egg
Extracting git_multimail-1.5.0-py3.10.egg to /usr/local/lib/python3.10/dist-packages
Adding git-multimail 1.5.0 to easy-install.pth file
Installing git_multimail.py script to /usr/local/bin
...

vimer@dev:~/build/rfs/git-multimail$ which git_multimail.py
/usr/local/bin/git_multimail.py
```

It looks like you said. The git_multimail.py is placed in
/usr/local/bin/git_multimail.py (if from debian package, it will be
placed into /usr/bin/)

The content of git-multimail.deb is:

```
   This package provides the Python 3 modules and the git-multimail script.

drwxr-xr-x root/root         0 2022-09-14 09:11 ./
drwxr-xr-x root/root         0 2022-09-14 09:11 ./usr/
drwxr-xr-x root/root         0 2022-09-14 09:11 ./usr/bin/
-rwxr-xr-x root/root    161143 2022-09-14 09:11 ./usr/bin/git_multimail.py
drwxr-xr-x root/root         0 2022-09-14 09:11 ./usr/lib/
drwxr-xr-x root/root         0 2022-09-14 09:11 ./usr/lib/python3/
drwxr-xr-x root/root         0 2022-09-14 09:11 ./usr/lib/python3/dist-packages/
drwxr-xr-x root/root         0 2022-09-14 09:11 ./usr/lib/python3/dist-packages/git_multimail-1.6.0.egg-info/
-rw-r--r-- root/root     35851 2022-09-14 09:11 ./usr/lib/python3/dist-packages/git_multimail-1.6.0.egg-info/PKG-INFO
-rw-r--r-- root/root         1 2022-09-14 09:11 ./usr/lib/python3/dist-packages/git_multimail-1.6.0.egg-info/dependency_links.txt
-rw-r--r-- root/root        14 2022-09-14 09:11 ./usr/lib/python3/dist-packages/git_multimail-1.6.0.egg-info/top_level.txt
-rw-r--r-- root/root    161147 2022-07-21 07:30 ./usr/lib/python3/dist-packages/git_multimail.py
drwxr-xr-x root/root         0 2022-09-14 09:11 ./usr/share/
drwxr-xr-x root/root         0 2022-09-14 09:11 ./usr/share/doc/
drwxr-xr-x root/root         0 2022-09-14 09:11 ./usr/share/doc/git-multimail/
-rw-r--r-- root/root     11317 2022-07-21 07:30 ./usr/share/doc/git-multimail/README.rst.gz
-rw-r--r-- root/root       210 2022-09-14 09:11 ./usr/share/doc/git-multimail/changelog.Debian.gz
-rw-r--r-- root/root      1755 2022-09-14 09:11 ./usr/share/doc/git-multimail/copyright
```
I think the people found the issue also:
https://github.com/git-multimail/git-multimail/issues/221#issuecomment-1252529169

Certainly, lintian will give a kindly warning:
W: git-multimail: script-with-language-extension [usr/bin/git_multimail.py]

If I understand correctly, this is a bug as you said.
The workround is still to use launcher file in d/ as in previous commit?

Many thanks for your time to help me review it again :)

-- 
Regards,
--
   Bo YU

Back to linux.debian.bugs.dist | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Bug#1007025: I want to join the DPT Bastian Germann <bage@debian.org> - 2022-07-16 22:10 +0200
  Bug#1007025: I want to join the DPT Bo YU <tsu.yubo@gmail.com> - 2022-07-17 17:40 +0200
    Bug#1007025: git-multimail 1.6.0 package review Antoine Beaupré <anarcat@debian.org> - 2022-09-15 18:40 +0200
      Bug#1007025: git-multimail 1.6.0 package review Antoine Beaupré <anarcat@debian.org> - 2022-09-15 18:50 +0200
      Bug#1007025: git-multimail 1.6.0 package review Bo YU <tsu.yubo@gmail.com> - 2022-09-18 05:20 +0200
        Bug#1007025: git-multimail 1.6.0 package review Antoine Beaupré <anarcat@debian.org> - 2022-09-20 17:10 +0200
          Bug#1007025: git-multimail 1.6.0 package review Bo YU <tsu.yubo@gmail.com> - 2022-09-22 11:10 +0200
            Bug#1007025: git-multimail 1.6.0 package review Antoine Beaupré <anarcat@debian.org> - 2022-09-22 18:40 +0200

csiph-web