Path: csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: Bo YU Newsgroups: linux.debian.maint.python Subject: Re: Bug#1007025: git-multimail 1.6.0 package review Date: Sat, 24 Sep 2022 09:40:01 +0200 Message-ID: References: X-Original-To: Antoine =?utf-8?Q?Beaupr=C3=A9?= X-Mailbox-Line: From debian-python-request@lists.debian.org Sat Sep 24 07:34:42 2022 Old-Return-Path: X-Amavis-Spam-Status: No, score=-11.099 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FOURLA=0.1, FREEMAIL_FROM=0.001, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_NONE=-0.0001, SHIP_ID_INT=1] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -5.5 X-Gm-Message-State: ACrzQf0/mX7mX/+UVJMJgNdY6H949oKsLEAGDcgumljrmYAItFOlRMNO 6xIb4JoQ7xlFk9JSemQPeskQxnD+mSg= X-Google-SMTP-Source: AMsMyM715gE708hzTmqF49+/J6Tvf/ya40npb7E70c05kPr2U0HXx4BHeci47YBv96hos6bNMvi4rw== X-Received: by 2002:a17:90b:110a:b0:203:6f0c:9b66 with SMTP id gi10-20020a17090b110a00b002036f0c9b66mr13915526pjb.104.1664004861498; Sat, 24 Sep 2022 00:34:21 -0700 (PDT) X-PGP-Key: https://github.com/yuzibo/yuzibo.github.io/blob/master/_includes/subkey-signing-06-18-143E4BAF-pub.asc MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3huckft2sg3hbupe" Content-Disposition: inline X-Mailing-List: archive/latest/20339 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20220924073417.nfltltgrokonpj6m@debian Approved: robomod@news.nic.it Lines: 69 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: Jeroen Ploemen , debian-python@lists.debian.org X-Original-Date: Sat, 24 Sep 2022 15:34:17 +0800 X-Original-Message-ID: <20220924073417.nfltltgrokonpj6m@debian> X-Original-References: <164694434412.23888.15342309351823597252.reportbug@angela.anarc.at> <20220717152756.lyoqizifnfhykqrg@debian> <87illowqce.fsf@emma.anarc.at> <20220918031024.rehgofq4bc4k5hw4@debian> <164694434412.23888.15342309351823597252.reportbug@angela.anarc.at> <87mtau5c3e.fsf@curie.anarc.at> <20220922090324.ot6shgjve5p47gk2@debian> <87zger4bb3.fsf@curie.anarc.at> <20220922194324.5e5ed9d9@debian.org> <87wn9v46tk.fsf@curie.anarc.at> Xref: csiph.com linux.debian.maint.python:14496 --3huckft2sg3hbupe Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Sep 22, 2022 at 02:12:07PM -0400, Antoine Beaupr=E9 wrote: >On 2022-09-22 19:43:24, Jeroen Ploemen wrote: >> On Thu, 22 Sep 2022 12:35:12 -0400 >> Antoine Beaupr=E9 wrote: >> >>> I think the simplest solution is not to rewrite the launcher, but to >>> rename it. So in debian/rules, you would simply do: >>> >>> override_dh_auto_install: >>> dh_auto_install >>> mv debian/git-multimail/usr/bin/git_multimail.py >>> debian/git-multimail/usr/bin/git-multimail >> >> Antoine, IIRC the git_multimail.py file upstream installs into >> /usr/bin is not a launcher but a full copy of the module as installed >> into /usr/lib/python3. The code in that file auto-detects whether >> it's run as a program. > >Oh. I misunderstood that, sorry. Sorry, maybe my words misled you also here. > >> That resulted in two copies of that sizeable file in the package I >> reviewed back in June. Hence my suggestion - quoted in an earlier >> message by Bo - to replace the copy in /usr/bin with a tiny launcher, >> reducing the installed size of the package by almost half. > >Sure, that completely makes sense then, sorry. Ok, I have re-enabled the launcher and other issues fixed for git-multimail as your and jcfp's suggestions. Thanks all and please let me know if any issues. --=20 Regards, -- Bo YU --3huckft2sg3hbupe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEIcmhjYVTlmab0tjp+RVP3hQ+S68FAmMusvMACgkQ+RVP3hQ+ S69oRxAAgUzkemDaVZq5k3S5yqY75466xuz6OXc0+TTlDpVDhrSw/bNBKjjjO/lU SFlsmfYVUAPOOKeYm1bsq4SvVhmXkhb7S3nh9S98WM2KT0vDq2XdaOaJdjvjhSHI wiDbnyXIz6rlGNKXqka4SsvYeqjNBfjxSeF+qYUpcMuV/g7OAu4eO1Il9di4IOkc oimg+OeyZ7022eI+VLwhMKoTb9qhqJeR3DjqMfLnlhStmSGkV+ScMgCrv3awv8i3 VK3ipyeCqc9XK4GCmRxKGOiguniGEm5nIZxw9AKWf8jcFFnq+eCJ5oFWggumrudB u9+BOWkDscRH/wM+lD23OfI4vh1g/+ZLc1KxgQSeVQWhn9yKc8qkzNmM9yNPYt3a ALPK8G75LHG1qRpuYK5GtET3QdCxyQQYy8zt0WkKsxcwpLJGKRNaT6RxXnqmWzDC PLW339JkGulD6r/9vYVoV+kT0HryceZZtSiJ+5vqxSiqErgXpci6TaT8NL++rUQz 6vSlQhUu0xzTVNjS/PEMZFZ0oWtSiBrPBSvoE6z7yTdgCE4Y5QuFm2nlp3UrRUQ5 8k5JmCVNXzB4bzI2YBBG9s006xIcttzZXXE5WniEo9uYkrRq2FGE3iehIXaH2eE/ 4H9ug/irDIKfOVG4nPsSIeKPib7pA6KuvF/BiO2yqIfQzsyPeig= =iKL9 -----END PGP SIGNATURE----- --3huckft2sg3hbupe--