Groups > linux.debian.maint.python > #14489

Re: Bug#1007025: git-multimail 1.6.0 package review

Path	csiph.com!pasdenom.info!aioe.org!bofh.it!news.nic.it!robomod
From	Jeroen Ploemen <jcfp@debian.org>
Newsgroups	linux.debian.maint.python
Subject	Re: Bug#1007025: git-multimail 1.6.0 package review
Date	Thu, 22 Sep 2022 19:50:01 +0200
Message-ID	<F8yuJ-9loj-5@gated-at.bofh.it> (permalink)
References	<E2ogV-2BxD-3@gated-at.bofh.it> <E2ogV-2BxD-3@gated-at.bofh.it> <DZxJL-SUI-5@gated-at.bofh.it> <EJWgV-bNDG-5@gated-at.bofh.it> <DZxJL-SUI-5@gated-at.bofh.it> <EKexb-bZ4j-1@gated-at.bofh.it> <F6049-7JM1-3@gated-at.bofh.it> <F6T0B-8jE7-1@gated-at.bofh.it> <DZxJL-SUI-5@gated-at.bofh.it> <F7MT7-8RWZ-1@gated-at.bofh.it> <F8qnv-9gJB-1@gated-at.bofh.it> <F8xoZ-9kM1-1@gated-at.bofh.it>
X-Mailbox-Line	From debian-python-request@lists.debian.org Thu Sep 22 17:44:00 2022
Old-Return-Path	<jcfp@debian.org>
X-Amavis-Spam-Status	No, score=-111.81 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FOURLA=0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_LOW=-0.7, SHIP_ID_INT=1, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no
X-Mailer	Claws Mail 4.1.0 (GTK 3.24.20; x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	multipart/signed; boundary="Sig_/gwqM=9Ni2qoX0XeE1X28fWJ"; protocol="application/pgp-signature"; micalg=pgp-sha512
X-Debian-User	jcfp
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/20331
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/20220922194324.5e5ed9d9@debian.org
Approved	robomod@news.nic.it
Lines	47
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Cc	Antoine Beaupré <anarcat@debian.org>, Bo YU <tsu.yubo@gmail.com>
X-Original-Date	Thu, 22 Sep 2022 19:43:24 +0200
X-Original-Message-ID	<20220922194324.5e5ed9d9@debian.org>
X-Original-References	<8735jf8a0w.fsf@angela.anarc.at> <8735jf8a0w.fsf@angela.anarc.at> <164694434412.23888.15342309351823597252.reportbug@angela.anarc.at> <5062951b-5c19-60a6-daa9-8acde45eaef6@debian.org> <164694434412.23888.15342309351823597252.reportbug@angela.anarc.at> <20220717152756.lyoqizifnfhykqrg@debian> <87illowqce.fsf@emma.anarc.at> <20220918031024.rehgofq4bc4k5hw4@debian> <164694434412.23888.15342309351823597252.reportbug@angela.anarc.at> <87mtau5c3e.fsf@curie.anarc.at> <20220922090324.ot6shgjve5p47gk2@debian> <87zger4bb3.fsf@curie.anarc.at>
Xref	csiph.com linux.debian.maint.python:14489

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, 22 Sep 2022 12:35:12 -0400
Antoine Beaupré <anarcat@debian.org> wrote:

> I think the simplest solution is not to rewrite the launcher, but to
> rename it. So in debian/rules, you would simply do:
> 
> override_dh_auto_install:
>         dh_auto_install
>         mv debian/git-multimail/usr/bin/git_multimail.py
> debian/git-multimail/usr/bin/git-multimail

Antoine, IIRC the git_multimail.py file upstream installs into
/usr/bin is not a launcher but a full copy of the module as installed
into /usr/lib/python3. The code in that file auto-detects whether
it's run as a program.

That resulted in two copies of that sizeable file in the package I
reviewed back in June. Hence my suggestion - quoted in an earlier
message by Bo - to replace the copy in /usr/bin with a tiny launcher,
reducing the installed size of the package by almost half.

Thread

I want to join the DPT vimer <tsu.yubo@gmail.com> - 2022-03-17 09:50 +0100
  Re: I want to join the DPT Sandro Tosi <morph@debian.org> - 2022-03-17 14:20 +0100
    Re: I want to join the DPT vimer <tsu.yubo@gmail.com> - 2022-03-17 15:10 +0100
      Re: I want to join the DPT Sandro Tosi <morph@debian.org> - 2022-03-17 15:30 +0100
    Re: I want to join the DPT Sandro Tosi <morph@debian.org> - 2022-03-17 15:50 +0100
      Re: I want to join the DPT Bo YU <tsu.yubo@gmail.com> - 2022-03-18 10:10 +0100
        Bug#1007025: I want to join the DPT Antoine Beaupré <anarcat@debian.org> - 2022-03-18 14:40 +0100
          Bug#1007025: I want to join the DPT Bo YU <tsu.yubo@gmail.com> - 2022-03-18 15:30 +0100
            Bug#1007025: I want to join the DPT Antoine Beaupré <anarcat@debian.org> - 2022-03-18 18:10 +0100
              Bug#1007025: git-multimail 1.6.0 package review Antoine Beaupré <anarcat@debian.org> - 2022-09-15 18:40 +0200
                Bug#1007025: git-multimail 1.6.0 package review Antoine Beaupré <anarcat@debian.org> - 2022-09-15 18:50 +0200
                Bug#1007025: git-multimail 1.6.0 package review Bo YU <tsu.yubo@gmail.com> - 2022-09-18 05:20 +0200
                Bug#1007025: git-multimail 1.6.0 package review Antoine Beaupré <anarcat@debian.org> - 2022-09-20 17:10 +0200
                Bug#1007025: git-multimail 1.6.0 package review Bo YU <tsu.yubo@gmail.com> - 2022-09-22 11:10 +0200
                Bug#1007025: git-multimail 1.6.0 package review Antoine Beaupré <anarcat@debian.org> - 2022-09-22 18:40 +0200
                Re: Bug#1007025: git-multimail 1.6.0 package review Jeroen Ploemen <jcfp@debian.org> - 2022-09-22 19:50 +0200
                Re: Bug#1007025: git-multimail 1.6.0 package review Antoine Beaupré <anarcat@debian.org> - 2022-09-22 20:20 +0200
                Re: Bug#1007025: git-multimail 1.6.0 package review Bo YU <tsu.yubo@gmail.com> - 2022-09-24 09:40 +0200
                Re: Bug#1007025: git-multimail 1.6.0 package review Bo YU <tsu.yubo@gmail.com> - 2022-09-26 15:10 +0200
    Re: I want to join the DPT vimer <tsu.yubo@gmail.com> - 2022-03-17 16:00 +0100
      Re: I want to join the DPT Stefano Rivera <stefanor@debian.org> - 2022-03-27 00:20 +0100
        Re: I want to join the DPT Bo YU <tsu.yubo@gmail.com> - 2022-03-31 05:30 +0200

csiph-web