Path: csiph.com!pasdenom.info!aioe.org!bofh.it!news.nic.it!robomod From: Jeroen Ploemen Newsgroups: linux.debian.maint.python Subject: Re: Bug#1007025: git-multimail 1.6.0 package review Date: Thu, 22 Sep 2022 19:50:01 +0200 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Thu Sep 22 17:44:00 2022 Old-Return-Path: X-Amavis-Spam-Status: No, score=-111.81 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FOURLA=0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_LOW=-0.7, SHIP_ID_INT=1, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no X-Mailer: Claws Mail 4.1.0 (GTK 3.24.20; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/gwqM=9Ni2qoX0XeE1X28fWJ"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Debian-User: jcfp X-Mailing-List: archive/latest/20331 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20220922194324.5e5ed9d9@debian.org Approved: robomod@news.nic.it Lines: 47 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: Antoine =?UTF-8?B?QmVhdXByw6k=?= , Bo YU X-Original-Date: Thu, 22 Sep 2022 19:43:24 +0200 X-Original-Message-ID: <20220922194324.5e5ed9d9@debian.org> X-Original-References: <8735jf8a0w.fsf@angela.anarc.at> <8735jf8a0w.fsf@angela.anarc.at> <164694434412.23888.15342309351823597252.reportbug@angela.anarc.at> <5062951b-5c19-60a6-daa9-8acde45eaef6@debian.org> <164694434412.23888.15342309351823597252.reportbug@angela.anarc.at> <20220717152756.lyoqizifnfhykqrg@debian> <87illowqce.fsf@emma.anarc.at> <20220918031024.rehgofq4bc4k5hw4@debian> <164694434412.23888.15342309351823597252.reportbug@angela.anarc.at> <87mtau5c3e.fsf@curie.anarc.at> <20220922090324.ot6shgjve5p47gk2@debian> <87zger4bb3.fsf@curie.anarc.at> Xref: csiph.com linux.debian.maint.python:14489 --Sig_/gwqM=9Ni2qoX0XeE1X28fWJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 22 Sep 2022 12:35:12 -0400 Antoine Beaupr=C3=A9 wrote: > I think the simplest solution is not to rewrite the launcher, but to > rename it. So in debian/rules, you would simply do: >=20 > override_dh_auto_install: > dh_auto_install > mv debian/git-multimail/usr/bin/git_multimail.py > debian/git-multimail/usr/bin/git-multimail Antoine, IIRC the git_multimail.py file upstream installs into /usr/bin is not a launcher but a full copy of the module as installed into /usr/lib/python3. The code in that file auto-detects whether it's run as a program. That resulted in two copies of that sizeable file in the package I reviewed back in June. Hence my suggestion - quoted in an earlier message by Bo - to replace the copy in /usr/bin with a tiny launcher, reducing the installed size of the package by almost half. --Sig_/gwqM=9Ni2qoX0XeE1X28fWJ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmMsnr0ACgkQQoMEoXSN zHpZZBAAi7qte5IznijgM9szsU4DcTmpzn9PRLaGnKjd71iW67jzwJhYUotJAWn4 QnEfD857kR2+qzQHHSMgn/s3sKHyx8U+j/lEwg8CtLSfeGxW5uFoQc+e0A3NUAmA ozWJU916SRKuPGTbiN3jf5SQ7jy85YzYQLa0+KulpCKQHmEKGxVM3pyjWjo3ZP8t XlZJDlv09L/zxxx82sh6GT1ycyC/S8Px9gN/7PUCBaLW5WbbXxJHENLebfZeTko4 a4MmBeDWflCoRnricBTNPW5c1yNdh5PzDiPTpsmLSm9FduPNaO0wVvodH9uNYDik /7BDkI7z/FYEah9nZj4+gz+ulNag2E+8S6ERto0uyS0tYYvetgurmnZ5YGIPasel hioeY83TIXhZGSIpegLFg9Yn7KXxs+WudsYgs1ESuP34LzYtqsLZc5Z0qHiWkZOg DcSzVWe9LgksFCVBaY+UU7BICd2+dlHXiIdHOuQp4ne9Rg8i7ptR2uqB1l9Q05Vb CZg+ZisXfQQSuJyC5LIvG7PEuPAYMkQgaERZZp7jQb0tOWa9BsdeTIQBHgfNiW0d b74QNoVfmbQSZChGYe3/5GE/K0AkGCvmUhpnIenpVM79DUGdcSEgg0dgjVWExgiB gzTutEmJux//ANkwYXUH+1SHoEZbHAO7uoeqi1Uho12Cx2/zmQ0= =H6iS -----END PGP SIGNATURE----- --Sig_/gwqM=9Ni2qoX0XeE1X28fWJ--