Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.maint.python > #13079
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Louis-Philippe Véronneau <pollo@debian.org> |
| Newsgroups | linux.debian.maint.python |
| Subject | python-mongoengine 0.21.0-1 review |
| Date | Thu, 24 Dec 2020 06:40:02 +0100 |
| Message-ID | <BprvY-4cg-19@gated-at.bofh.it> (permalink) |
| X-Mailbox-Line | From debian-python-request@lists.debian.org Thu Dec 24 05:31:32 2020 |
| Old-Return-Path | <pollo@debian.org> |
| X-Amavis-Spam-Status | No, score=-11.198 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, BODY_8BITS=1.5, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001] autolearn=ham autolearn_force=no |
| X-Policyd-Weight | using cached result; rate:hard: -4.6 |
| X-Riseup-User-ID | 02E6CBA9824C4A7097E413F25F56F0D13A7B2A2FB3414036E680AEEA1F803236 |
| MIME-Version | 1.0 |
| Content-Type | multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TJoU9RPqFV5OwBGJtMy4QJBueMyOqQmu5" |
| X-Mailing-List | <debian-python@lists.debian.org> archive/latest/18852 |
| List-ID | <debian-python.lists.debian.org> |
| List-URL | <https://lists.debian.org/debian-python/> |
| List-Archive | https://lists.debian.org/msgid-search/26a99a65-70a4-151f-f187-53a7f3cf7574@debian.org |
| Approved | robomod@news.nic.it |
| Lines | 75 |
| Organization | linux.* mail to news gateway |
| Sender | robomod@news.nic.it |
| X-Original-Cc | debian-python@lists.debian.org |
| X-Original-Date | Thu, 24 Dec 2020 00:30:54 -0500 |
| X-Original-Message-ID | <26a99a65-70a4-151f-f187-53a7f3cf7574@debian.org> |
| Xref | csiph.com linux.debian.maint.python:13079 |
Show key headers only | View raw
[Multipart message — attachments visible in raw view] - view raw
Hi, I've just finished reviewing your RFS for python-mongoengine 0.21.0-1 and it all looks good! I can't help but notice you are using the tarballs from pypi though, which means you don't have access to the upstream testsuite :( Do you think it would be possible to migrate to the github one and have your package run the tests? I would also suggest running them as an autopkgtests (here's an example [1]). That would give you a non superficial one :) If you don't have time to do that right now, I'd be happy to sponsor your package as-is if you commit to trying that out for the next release. Keep me posted! NB: I've removed your package from the sponsor queue on IRC so that others don't inadvertently review it a second time :) [1]: https://salsa.debian.org/python-team/packages/python-itemloaders/-/blob/debian/master/debian/tests/unittests -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ Louis-Philippe Véronneau ⢿⡄⠘⠷⠚⠋ pollo@debian.org / veronneau.org ⠈⠳⣄
Back to linux.debian.maint.python | Previous | Next — Next in thread | Find similar | Unroll thread
python-mongoengine 0.21.0-1 review Louis-Philippe Véronneau <pollo@debian.org> - 2020-12-24 06:40 +0100 Re: python-mongoengine 0.21.0-1 review Louis-Philippe Véronneau <pollo@debian.org> - 2020-12-24 21:50 +0100
csiph-web