Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #13079

python-mongoengine 0.21.0-1 review

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

I've just finished reviewing your RFS for python-mongoengine 0.21.0-1
and it all looks good!

I can't help but notice you are using the tarballs from pypi though,
which means you don't have access to the upstream testsuite :(

Do you think it would be possible to migrate to the github one and have
your package run the tests?

I would also suggest running them as an autopkgtests (here's an example
[1]). That would give you a non superficial one :)

If you don't have time to do that right now, I'd be happy to sponsor
your package as-is if you commit to trying that out for the next release.

Keep me posted!

NB: I've removed your package from the sponsor queue on IRC so that
others don't inadvertently review it a second time :)

[1]:
https://salsa.debian.org/python-team/packages/python-itemloaders/-/blob/debian/master/debian/tests/unittests

-- 
  ⢀⣴⠾⠻⢶⣦⠀
  ⣾⠁⢠⠒⠀⣿⡁  Louis-Philippe Véronneau
  ⢿⡄⠘⠷⠚⠋   pollo@debian.org / veronneau.org
  ⠈⠳⣄

Back to linux.debian.maint.python | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

python-mongoengine 0.21.0-1 review Louis-Philippe Véronneau <pollo@debian.org> - 2020-12-24 06:40 +0100
  Re: python-mongoengine 0.21.0-1 review Louis-Philippe Véronneau <pollo@debian.org> - 2020-12-24 21:50 +0100

csiph-web