Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: =?UTF-8?Q?Louis-Philippe_V=c3=a9ronneau?= Newsgroups: linux.debian.maint.python Subject: python-mongoengine 0.21.0-1 review Date: Thu, 24 Dec 2020 06:40:02 +0100 Message-ID: X-Mailbox-Line: From debian-python-request@lists.debian.org Thu Dec 24 05:31:32 2020 Old-Return-Path: X-Amavis-Spam-Status: No, score=-11.198 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, BODY_8BITS=1.5, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate:hard: -4.6 X-Riseup-User-ID: 02E6CBA9824C4A7097E413F25F56F0D13A7B2A2FB3414036E680AEEA1F803236 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TJoU9RPqFV5OwBGJtMy4QJBueMyOqQmu5" X-Mailing-List: archive/latest/18852 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/26a99a65-70a4-151f-f187-53a7f3cf7574@debian.org Approved: robomod@news.nic.it Lines: 75 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Thu, 24 Dec 2020 00:30:54 -0500 X-Original-Message-ID: <26a99a65-70a4-151f-f187-53a7f3cf7574@debian.org> Xref: csiph.com linux.debian.maint.python:13079 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TJoU9RPqFV5OwBGJtMy4QJBueMyOqQmu5 Content-Type: multipart/mixed; boundary="xUAqMnCBbAcJvrEWKtarrG8xILmkxfu4t"; protected-headers="v1" From: =?UTF-8?Q?Louis-Philippe_V=c3=a9ronneau?= To: =?UTF-8?Q?H=c3=a5vard_Flaget_Aasen?= Cc: debian-python@lists.debian.org Message-ID: <26a99a65-70a4-151f-f187-53a7f3cf7574@debian.org> Subject: python-mongoengine 0.21.0-1 review --xUAqMnCBbAcJvrEWKtarrG8xILmkxfu4t Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi, I've just finished reviewing your RFS for python-mongoengine 0.21.0-1 and it all looks good! I can't help but notice you are using the tarballs from pypi though, which means you don't have access to the upstream testsuite :( Do you think it would be possible to migrate to the github one and have your package run the tests? I would also suggest running them as an autopkgtests (here's an example [1]). That would give you a non superficial one :) If you don't have time to do that right now, I'd be happy to sponsor your package as-is if you commit to trying that out for the next release.= Keep me posted! NB: I've removed your package from the sponsor queue on IRC so that others don't inadvertently review it a second time :) [1]: https://salsa.debian.org/python-team/packages/python-itemloaders/-/blob/d= ebian/master/debian/tests/unittests --=20 =E2=A2=80=E2=A3=B4=E2=A0=BE=E2=A0=BB=E2=A2=B6=E2=A3=A6=E2=A0=80 =E2=A3=BE=E2=A0=81=E2=A2=A0=E2=A0=92=E2=A0=80=E2=A3=BF=E2=A1=81 Louis-= Philippe V=C3=A9ronneau =E2=A2=BF=E2=A1=84=E2=A0=98=E2=A0=B7=E2=A0=9A=E2=A0=8B pollo@debian.o= rg / veronneau.org =E2=A0=88=E2=A0=B3=E2=A3=84 --xUAqMnCBbAcJvrEWKtarrG8xILmkxfu4t-- --TJoU9RPqFV5OwBGJtMy4QJBueMyOqQmu5 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEEZ39U8fqGga2OwLzmeurE7GqqCpcFAl/kJ44FAwAAAAAACgkQeurE7GqqCpdb Zw//UV0oDx1ynnxC1zIqGyqIJxth5nZaPXSF17eGW1slKIuYk8HNHRZ/CHSTa+6wPtTYTU0LPvzs w7Lb+DIu/3UV9YYmX9rSGKh9AKaW9/as+y3VXYIdDshIruSk+PTuYYABejTQMiOnlU1/ty0+zCAM JfQpWpia7aFQIYF/P/ILwgpRnaQUxJt3x5AB+RvqXuHF2ElPLtahxZu3fg0SPl05e1/DAEAMoNLk xuiq+10Ds1B3TfOcvGnhQVv2h7nBmLsYWCBKFPqFkhKM3zWeQTvfxbGLjpHkqAB0DJ8mF0VayNLs bPB2srfAr4h4aCQsL0Ql2aTGP//dgBuigui3mgfnlOByMNwQuta5YhIgIV5RPQ+Rfd87Am6wzO7Y BrB3Ge5QQs4Hw9YV0/nwddfNDK6ay1jqPRGGI4WNSnT5dl/ehgDilD2xEZ8R8FOIl9fpXZTm97fs 0Qaqc4zokq7IRfbqXScZqPEVopfpZGQwXYK7pfgawTT1b0S5xijR9BwV0ogRe7xJNTdeFZxtzpw4 Qv/lr/PgFUQrJvsiB+2oVnDZmIvNbGbLpEpxsU9kGEjpuwF6bj5sZp0o01P9ZTnIbsofScsBEd+z bltK1CCU09Lh85WhwH77kFKypU2Kx9Dr2OdcF4yxXIVl968KMT60y+zIgugcTK2UrrqMNa05dfQw Qrs= =qw2X -----END PGP SIGNATURE----- --TJoU9RPqFV5OwBGJtMy4QJBueMyOqQmu5--