Groups > linux.debian.maint.python > #13080

Re: python-mongoengine 0.21.0-1 review

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Louis-Philippe Véronneau <pollo@debian.org>
Newsgroups	linux.debian.maint.python
Subject	Re: python-mongoengine 0.21.0-1 review
Date	Thu, 24 Dec 2020 21:50:01 +0100
Message-ID	<BpFIB-4Mp-5@gated-at.bofh.it> (permalink)
References	<BprvY-4cg-19@gated-at.bofh.it> <BpFIB-4Mp-7@gated-at.bofh.it>
X-Mailbox-Line	From debian-python-request@lists.debian.org Thu Dec 24 20:44:59 2020
Old-Return-Path	<pollo@debian.org>
X-Amavis-Spam-Status	No, score=-11.198 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, BODY_8BITS=1.5, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001] autolearn=ham autolearn_force=no
X-Policyd-Weight	using cached result; rate: -4.6
X-Riseup-User-ID	37F360FC14E7FC465948670D5A2D8B6AE86B512AE7E2CF064072F2FAAE756860
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZqPD1u1uUspfGIjKltGUKBTNNCkhN7uNh"
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/18854
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/76e17fb9-2014-f5aa-29b5-ea85136ad195@debian.org
Approved	robomod@news.nic.it
Lines	91
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Date	Thu, 24 Dec 2020 15:44:30 -0500
X-Original-Message-ID	<76e17fb9-2014-f5aa-29b5-ea85136ad195@debian.org>
X-Original-References	<26a99a65-70a4-151f-f187-53a7f3cf7574@debian.org> <CAO9NP94E25ARLzRVDUGfcY1EB9shoDxA29Vun6JmidNhU1-vZw@mail.gmail.com>
Xref	csiph.com linux.debian.maint.python:13080

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On 2020-12-24 09 h 45, Håvard Flaget Aasen wrote:
> Hi,
> 
> Thanks for the review!
> 
> tor. 24. des. 2020 kl. 05:31 skrev Louis-Philippe Véronneau <pollo@debian.org>:
>>
>> Hi,
>>
>> I've just finished reviewing your RFS for python-mongoengine 0.21.0-1
>> and it all looks good!
>>
>> I can't help but notice you are using the tarballs from pypi though,
>> which means you don't have access to the upstream testsuite :(
>>
>> Do you think it would be possible to migrate to the github one and have
>> your package run the tests?
> 
> I tested with the tarball from GitHub today, and almost all of the
> tests is testing against a MongoDB server, which we don't have. This
> of course means that almost all test fails. I'm not sure how much
> value it is to run the remaining tests during build.
> 
> As for the autopkgtest, there might be possible to download, install,
> and run MongoDB during the test, that's what upstream is doing when
> they test the package, but that must be stretching what we can and
> should do when running autopkgtest in Debian.
> 
> I'm open for suggestion here, but since we don't have the necessary
> package in the repository I believe it will be difficult to test this
> package properly.

This all makes a lot of sense, thanks for looking into it. I've
sponsored the package as-is.

Thanks for you contribution to Debian.

PS: as per policy, I renamed the "master" branch to "debian/master".

-- 
  ⢀⣴⠾⠻⢶⣦⠀
  ⣾⠁⢠⠒⠀⣿⡁  Louis-Philippe Véronneau
  ⢿⡄⠘⠷⠚⠋   pollo@debian.org / veronneau.org
  ⠈⠳⣄

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

python-mongoengine 0.21.0-1 review Louis-Philippe Véronneau <pollo@debian.org> - 2020-12-24 06:40 +0100
  Re: python-mongoengine 0.21.0-1 review Louis-Philippe Véronneau <pollo@debian.org> - 2020-12-24 21:50 +0100

csiph-web