Path: csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: =?UTF-8?Q?Louis-Philippe_V=c3=a9ronneau?= Newsgroups: linux.debian.maint.python Subject: Re: python-mongoengine 0.21.0-1 review Date: Thu, 24 Dec 2020 21:50:01 +0100 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Thu Dec 24 20:44:59 2020 Old-Return-Path: X-Amavis-Spam-Status: No, score=-11.198 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, BODY_8BITS=1.5, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -4.6 X-Riseup-User-ID: 37F360FC14E7FC465948670D5A2D8B6AE86B512AE7E2CF064072F2FAAE756860 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZqPD1u1uUspfGIjKltGUKBTNNCkhN7uNh" X-Mailing-List: archive/latest/18854 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/76e17fb9-2014-f5aa-29b5-ea85136ad195@debian.org Approved: robomod@news.nic.it Lines: 91 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Date: Thu, 24 Dec 2020 15:44:30 -0500 X-Original-Message-ID: <76e17fb9-2014-f5aa-29b5-ea85136ad195@debian.org> X-Original-References: <26a99a65-70a4-151f-f187-53a7f3cf7574@debian.org> Xref: csiph.com linux.debian.maint.python:13080 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ZqPD1u1uUspfGIjKltGUKBTNNCkhN7uNh Content-Type: multipart/mixed; boundary="yRb1ZAzuuF5wPCLRMHw46l5sXAkTFJnVb"; protected-headers="v1" From: =?UTF-8?Q?Louis-Philippe_V=c3=a9ronneau?= To: debian-python@lists.debian.org Message-ID: <76e17fb9-2014-f5aa-29b5-ea85136ad195@debian.org> Subject: Re: python-mongoengine 0.21.0-1 review References: <26a99a65-70a4-151f-f187-53a7f3cf7574@debian.org> In-Reply-To: --yRb1ZAzuuF5wPCLRMHw46l5sXAkTFJnVb Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2020-12-24 09 h 45, H=C3=A5vard Flaget Aasen wrote: > Hi, >=20 > Thanks for the review! >=20 > tor. 24. des. 2020 kl. 05:31 skrev Louis-Philippe V=C3=A9ronneau : >> >> Hi, >> >> I've just finished reviewing your RFS for python-mongoengine 0.21.0-1 >> and it all looks good! >> >> I can't help but notice you are using the tarballs from pypi though, >> which means you don't have access to the upstream testsuite :( >> >> Do you think it would be possible to migrate to the github one and hav= e >> your package run the tests? >=20 > I tested with the tarball from GitHub today, and almost all of the > tests is testing against a MongoDB server, which we don't have. This > of course means that almost all test fails. I'm not sure how much > value it is to run the remaining tests during build. >=20 > As for the autopkgtest, there might be possible to download, install, > and run MongoDB during the test, that's what upstream is doing when > they test the package, but that must be stretching what we can and > should do when running autopkgtest in Debian. >=20 > I'm open for suggestion here, but since we don't have the necessary > package in the repository I believe it will be difficult to test this > package properly. This all makes a lot of sense, thanks for looking into it. I've sponsored the package as-is. Thanks for you contribution to Debian. PS: as per policy, I renamed the "master" branch to "debian/master". --=20 =E2=A2=80=E2=A3=B4=E2=A0=BE=E2=A0=BB=E2=A2=B6=E2=A3=A6=E2=A0=80 =E2=A3=BE=E2=A0=81=E2=A2=A0=E2=A0=92=E2=A0=80=E2=A3=BF=E2=A1=81 Louis-= Philippe V=C3=A9ronneau =E2=A2=BF=E2=A1=84=E2=A0=98=E2=A0=B7=E2=A0=9A=E2=A0=8B pollo@debian.o= rg / veronneau.org =E2=A0=88=E2=A0=B3=E2=A3=84 --yRb1ZAzuuF5wPCLRMHw46l5sXAkTFJnVb-- --ZqPD1u1uUspfGIjKltGUKBTNNCkhN7uNh Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEEZ39U8fqGga2OwLzmeurE7GqqCpcFAl/k/a4FAwAAAAAACgkQeurE7GqqCpdC Tw//ZL15a8UmZ8N76k8KoBc6PtOwG79F9mEJ1aJMkvQPrU1vylvWO+hbtjgEpQVpbZ2GmVE3EiNZ vWas0S6InCBSiBMJ7weQFy+GOWZag3OEcr50WVcacryWrZrEB7tjTGbzfqAxFo+qgJIq3gQMOGj0 IkGshr/4dGDd4s0CyiIiqsHgO0ZQkzvRGeOUgOU4Lzi8ea2SHF1VEGQzvnTGfGWId/jPwcvyi40h S18IU7FSotUL53+4S+DAdCskTTGOevEf03wueAP7HOjC2ey3mqD6DCbKVSaNZwe8RLLXegZN54lh uE9TwqM4dzZ7/PtFPcRkNY85fjcrGUHqvT0nJ/fEICbiVUlPruj7X3jDUYu0MxQ0DrwMHwtel9Ah mRc01w/Ua+Q7g7/LZABHFt8k2WMWB+Cs9ZSFk8tw2PK8weRYilnYHIqtXBUrNG3HwKL9yLHGZIn7 m7lkXSgTck//mOSmHv3X0Hktg5Ck29omLjBANs2UBMuZ0ZFPjscpA2v1npIy51DW6ZTgZeG9kG9t FiCgK+NoBT1tEUzUo3gkrOI7b8sNomLPHEaFfsNPS1TV/5bdd15baOGP0N1zEesTM2ViZrlmo0Hi UhzG/z6I9VdFgw/ylLEyMtBmG2G0b96JIwRG47yGFLphHIRKEv9oaAy5YYTaOoUTQR0dMz1FQNrm gV0= =Fpac -----END PGP SIGNATURE----- --ZqPD1u1uUspfGIjKltGUKBTNNCkhN7uNh--