Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.javascript > #21059

Re: Multiple image preload construct?

Show key headers only | View raw

Ken wrote:
^^^
Please fix, Ken #4711.

> On 27.08.2013 09:32, Tuxedo wrote:
>> How can this be constructed in a simple way to run the function block
>> after two images have preloaded? Eg. after:
>> preload_img.src = 'image_1.jpg' AND 'image_2.jpg';
>> .... is complete?
> 
> You need to keep track with a counter, for example:
> 
>      var images = ['img1url', 'img2url', 'img2url', ...];
> 
>      /// function to load all images in an array with urls

In these languages (not C#), documentation comments are better written
/*… */,  for “//” introduces single-line comments that are best used only 
for disabling code (and be used carefully on Usenet with its not fully 
defined line length).

>      function loadImages(imgs, callback) {
> 
>          var i = 0, img, count = imgs.length, result = [];
> 
>          /// create images
>          for(; img = imgs[i]; i++) {

That is awful code style for array iteration, in probably every language of 
the C family.  Consider this instead:

  for (var i = 0, count = len = imgs.length; i < len; ++i)
  {

>              var newImage = new Image();
>              result.push(newImage);
>              newImage.onload = handleLoad;
>              newImage.src = img;

It makes more sense to append the object reference to the Array *after* the 
object is prepared:

  var newImage = new Image();
  newImage.onload = handleLoad;
  newImage.src = img;
  result.push(newImage);

>          }
> 
>          function handleLoad() {
>              count--;
>              if (count === 0) callback(result);

Consider

  if (!--count)
  {
    callback(result);
  }

or

  if (--count === 0)
  {
    callback(result);
  }

You could also count upwards (naming the variable “loadCount”, for example).  
And you actually need only one Array, as ECMAScript Arrays are not typed by 
default:

  var img = new Image();
  …
  img.src = imgs[i];
  imgs[i] = img;

It is even questionable to have the Image instance references in an Array, 
as then there is no random access to them, for example by name or ID.

>          }
>      }
> 
> Now you can call the function:
> 
>      loadImages(myArray, loadDone);
> 
>      function loadDone(result)  {
>          console.log('All images loaded!');
>          /// result contains an array with the Image elements
>      }

Function expressions are widely supported by now, especially where 
console.log() is supported [1]:

  loadImages(myArray, function (result) {
    console.log('All images loaded!');
    /* result contains an array with the Image elements */
  });

[1] <http://PointedEars.de/es-matrix?filter=function>

Using your way is only necessary with event-handler properties, and probably 
only for *older* versions of JScript/IE (to work around the memory leak 
issue).

In your code you declare 3 global properties that should be avoided by using 
namespacing (for lack of a better word):

  var namespace = {
    …

    loadImages: function (/* … */) {
      // …
    }
  };

or, if necessary, by module pattern:

  var module = (function () {
    var _myPrivateVar;

    …

    return {
      …

      loadImages: function (/* … */) {
        // … access _myPrivateVar
      }
    };
  }());

See <http://PointeEars.de/scripts/test/hoverMe> for a better approach.  
(Although the image references are currently borken, the code should work.)

-- 
PointedEars

Twitter: @PointedEars2
Please do not Cc: me. / Bitte keine Kopien per E-Mail.

Back to comp.lang.javascript | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Multiple image preload construct? Tuxedo <tuxedo@mailinator.com> - 2013-08-27 16:32 +0200
  Re: Multiple image preload construct? Tuxedo <tuxedo@mailinator.com> - 2013-08-27 17:06 +0200
  Re: Multiple image preload construct? Danny <dann90038@gmail.com> - 2013-08-27 10:29 -0700
  Re: Multiple image preload construct? Ken <usenet-so@abdiassoftware.com> - 2013-08-27 13:32 -0500
    Re: Multiple image preload construct? Tuxedo <tuxedo@mailinator.com> - 2013-08-27 20:54 +0200
      Re: Multiple image preload construct? Ken <usenet-so@abdiassoftware.com> - 2013-08-27 18:19 -0500
        Re: Multiple image preload construct? Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2013-08-28 01:37 +0200
          Re: Multiple image preload construct? Ken <usenet-so@abdiassoftware.com> - 2013-08-27 18:47 -0500
    Re: Multiple image preload construct? Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2013-08-27 23:02 +0200
      Re: Multiple image preload construct? Cezary Tomczyk <cezary.tomczyk@gmail.com> - 2013-08-27 23:20 +0200
        Re: Multiple image preload construct? Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2013-08-28 01:27 +0200
          Re: Multiple image preload construct? Cezary Tomczyk <cezary.tomczyk@gmail.com> - 2013-08-29 03:56 +0200
            Re: Multiple image preload construct? Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2013-08-29 15:16 +0200
      Re: Multiple image preload construct? Ken <usenet-so@abdiassoftware.com> - 2013-08-27 18:43 -0500
        Re: Multiple image preload construct? Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2013-08-28 02:08 +0200
          Re: Multiple image preload construct? Ken <usenet-so@abdiassoftware.com> - 2013-08-27 19:49 -0500
            Re: Multiple image preload construct? Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2013-08-28 03:17 +0200
              Re: Multiple image preload construct? Ken <usenet-so@abdiassoftware.com> - 2013-08-27 20:35 -0500
                Re: Multiple image preload construct? Dr J R Stockton <reply1300@merlyn.demon.co.uk.invalid> - 2013-08-29 19:32 +0100
              Re: Multiple image preload construct? John Harris <niam@jghnorth.org.uk.invalid> - 2013-08-28 16:20 +0100
            Re: Multiple image preload construct? Andrew Poulos <ap_prog@hotmail.com> - 2013-08-28 11:21 +1000
              Re: Multiple image preload construct? Ken <usenet-so@abdiassoftware.com> - 2013-08-27 20:48 -0500
                Re: Multiple image preload construct? Andrew Poulos <ap_prog@hotmail.com> - 2013-08-28 13:43 +1000
                Re: Multiple image preload construct? John Harris <niam@jghnorth.org.uk.invalid> - 2013-08-29 10:00 +0100
                Re: Multiple image preload construct? Andrew Poulos <ap_prog@hotmail.com> - 2013-08-30 07:25 +1000
                Re: Multiple image preload construct? John Harris <niam@jghnorth.org.uk.invalid> - 2013-08-30 10:11 +0100
        Re: Multiple image preload construct? Christoph Michael Becker <cmbecker69@arcor.de> - 2013-08-28 02:17 +0200
          Re: Multiple image preload construct? Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2013-08-28 02:38 +0200
      Re: Multiple image preload construct? Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2013-08-28 11:04 +0200
      Re: Multiple image preload construct? John Harris <niam@jghnorth.org.uk.invalid> - 2013-08-28 16:26 +0100

csiph-web