Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.java.programmer > #32934

Re: What goes wrong with cloning here

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Saturday 24 Oct 2015 00:51 CEST, Cecil Westerhof wrote:

> On Friday 23 Oct 2015 18:12 CEST, Tassilo Horn wrote:
>
>> Cecil Westerhof <Cecil@decebal.nl> writes:
>>
>>> When I in class A change a field from class B in the clone, the
>>> field in the original is also changed. That should not happen.
>>>
>>> public class A implements Cloneable {
>>> 	private B key;
>>> ^^^
>>> 	public Object clone() throws CloneNotSupportedException {
>>> 		A clone  = (A) super.clone();
>>> 		B newKey = new B();
>>> B oldKey = getKey();
>>>
>>> 		newKey.setA(oldKey.getA());
>>> 		newKey.setB(oldKey.getB());
>>> 		newKey.setC(oldKey.getC());
>>> 		newKey.setD(oldKey.getD());
>>> 		clone.setKey(key);
>> ^^^
>>
>> I guess here you want to set the key of the clone to newKey, not to
>> this.key.
>
> Was an error in my dumbing down. :'-( In the original program it was
> done correctly.
>
>
> I found the problem. It is an application where the class is a JPA
> class. When doing the test (in the original program) with an entity
> that was gotten by a read it goes wrong. When doing it with an
> entity gotten by a new it does what I expect.
>
> Maybe it has to do with the fact that key is the primary key?

For if someone is interested. I rewrote the code. I made the class B
Cloneable again. (Was like this before my first post, but I was
thinking that maybe there went something wrong.) When class B changes
class A does not need to change. Also added hashCode to toString.

Back to comp.lang.java.programmer | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

What goes wrong with cloning here Cecil Westerhof <Cecil@decebal.nl> - 2015-10-23 17:49 +0200
  Re: What goes wrong with cloning here Tassilo Horn <tsdh@gnu.org> - 2015-10-23 18:12 +0200
    Re: What goes wrong with cloning here Cecil Westerhof <Cecil@decebal.nl> - 2015-10-24 00:51 +0200
      Re: What goes wrong with cloning here Cecil Westerhof <Cecil@decebal.nl> - 2015-10-24 01:44 +0200

csiph-web