Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.java.programmer > #32932

Re: What goes wrong with cloning here

Show all headers | View raw

Cecil Westerhof <Cecil@decebal.nl> writes:

> When I in class A change a field from class B in the clone, the field
> in the original is also changed. That should not happen.
>
> public class A implements Cloneable {
> 	private B key;
>                 ^^^
> 	public Object clone() throws CloneNotSupportedException {
> 		A clone  = (A) super.clone();
> 		B newKey = new B();
>         B oldKey = getKey();
>
> 		newKey.setA(oldKey.getA());
> 		newKey.setB(oldKey.getB());
> 		newKey.setC(oldKey.getC());
> 		newKey.setD(oldKey.getD());
> 		clone.setKey(key);
                             ^^^

I guess here you want to set the key of the clone to newKey, not to
this.key.

Bye,
Tassilo

Back to comp.lang.java.programmer | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

What goes wrong with cloning here Cecil Westerhof <Cecil@decebal.nl> - 2015-10-23 17:49 +0200
  Re: What goes wrong with cloning here Tassilo Horn <tsdh@gnu.org> - 2015-10-23 18:12 +0200
    Re: What goes wrong with cloning here Cecil Westerhof <Cecil@decebal.nl> - 2015-10-24 00:51 +0200
      Re: What goes wrong with cloning here Cecil Westerhof <Cecil@decebal.nl> - 2015-10-24 01:44 +0200

csiph-web