Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.python > #18796

Re: Newbie: Looking for code review on my first Python project.

Show all headers | View raw

On 1/10/2012 8:17 PM, Ian Kelly wrote:
> On Tue, Jan 10, 2012 at 4:44 PM, HoneyMonster<someone@someplace.invalid>  wrote:
>> Hi,
>>
>> I'm new to Python and recently completed my first project. I used
>> wxPython with wxGlade to generate the GUI bits.The application seems to
>> work well, but I am entirely self-taught, so have undoubtedly committed a
>> number of howlers in terms of style, design, standards, best practice and
>> so forth.
>>
>> Is there any kind soul here who would be willing to take a look at the
>> code and offer comments?  The code is at:
>> <http://dl.dropbox.com/u/6106778/bbc.py>
>
> Okay, here goes. :-)

Nice review. Though OP used and you wrote about wx, when I get deeper 
into the IDLE code, I will look to see whether tkinter/idle resource 
provide context managers (if not, try to add) and whether idle is using 
them. (I won't be surprised if answers are often no and no.)

-- 
Terry Jan Reedy

Back to comp.lang.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Newbie: Looking for code review on my first Python project. HoneyMonster <someone@someplace.invalid> - 2012-01-10 23:44 +0000
  Re: Newbie: Looking for code review on my first Python project. Ian Kelly <ian.g.kelly@gmail.com> - 2012-01-10 18:17 -0700
    Re: Newbie: Looking for code review on my first Python project. HoneyMonster <someone@someplace.invalid> - 2012-01-11 11:39 +0000
      Re: Newbie: Looking for code review on my first Python project. HoneyMonster <someone@someplace.invalid> - 2012-01-11 21:09 +0000
        Re: Newbie: Looking for code review on my first Python project. 88888 Dihedral <dihedral88888@googlemail.com> - 2012-01-11 16:24 -0800
  Re: Newbie: Looking for code review on my first Python project. Chris Angelico <rosuav@gmail.com> - 2012-01-11 12:43 +1100
    Re: Newbie: Looking for code review on my first Python project. Ben Finney <ben+python@benfinney.id.au> - 2012-01-11 13:05 +1100
  Re: Newbie: Looking for code review on my first Python project. Terry Reedy <tjreedy@udel.edu> - 2012-01-10 20:50 -0500
  Re: Newbie: Looking for code review on my first Python project. Terry Reedy <tjreedy@udel.edu> - 2012-01-10 22:59 -0500
    Re: Newbie: Looking for code review on my first Python project. Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2012-01-11 04:24 +0000
    Re: Newbie: Looking for code review on my first Python project. Ben Finney <ben+python@benfinney.id.au> - 2012-01-11 16:23 +1100

csiph-web