Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > comp.lang.python > #18797

Re: your feedback to my first project please

From Terry Reedy <tjreedy@udel.edu>
Subject Re: your feedback to my first project please
Date 2012-01-10 20:53 -0500
References <4F0C45FA.2060505@sequans.com>
Newsgroups comp.lang.python
Message-ID <mailman.4623.1326246913.27778.python-list@python.org> (permalink)

Show all headers | View raw


On 1/10/2012 9:06 AM, Jean-Michel Pichavant wrote:

> - I quite dislike your avg method which does more than averaging, it
> also inserts a value and removes another modifying the object in place.
> It could be very confusing for someone reading your code. Fortunately,
> you have documented it, that makes it acceptable. Why don't you make avg
> only averaging. Surely you can use the add method right before.

Or use a better name, like running_average or run_mean (if that is what 
it is doing).

-- 
Terry Jan Reedy

Back to comp.lang.python | Previous | Next | Find similar | Unroll thread


Thread

Re: your feedback to my first project please Terry Reedy <tjreedy@udel.edu> - 2012-01-10 20:53 -0500

csiph-web