Path: csiph.com!x330-a1.tempe.blueboxinc.net!usenet.pasdenom.info!aioe.org!news.stack.nl!newsfeed.xs4all.nl!newsfeed6.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
Return-Path: <python-python-list@m.gmane.org>
X-Original-To: python-list@python.org
Delivered-To: python-list@mail.python.org
X-Spam-Status: OK 0.000
X-Spam-Evidence: '*H*': 1.00; '*S*': 0.00; 'context': 0.04; 'subject:Python': 0.05; ':-)': 0.06; 'forth.': 0.07; 'received:verizon.net': 0.07; 'subject:code': 0.07; 'terry': 0.07; 'url:py': 0.07; 'wxpython': 0.07; 'python': 0.08; 'received:80.91': 0.09; 'received:80.91.229': 0.09; 'received:80.91.229.12': 0.09; 'received:gmane.org': 0.09; 'received:list': 0.09; 'received:lo.gmane.org': 0.09; 'gui': 0.13; 'okay,': 0.16; 'reedy': 0.16; 'style,': 0.16; 'subject:Newbie': 0.16; 'wrote:': 0.18; 'jan': 0.19; 'seems': 0.20; 'wrote': 0.22; 'header:In-Reply-To:1': 0.22; 'code': 0.25; "i'm": 0.26; 'code,': 0.27; 'idle': 0.29; 'pm,': 0.29; 'comments?': 0.30; 'kelly': 0.30; 'hi,': 0.32; 'tue,': 0.32; "won't": 0.33; 'header:User-Agent:1': 0.33; 'header:X-Complaints-To:1': 0.33; 'there': 0.33; 'to:addr :python-list': 0.34; 'surprised': 0.34; 'but': 0.37; 'not,': 0.37; 'using': 0.38; 'answers': 0.38; 'received:org': 0.38; 'to:addr:python.org': 0.40; 'kind': 0.61; 'managers': 0.62; 'committed': 0.64; 'url:u': 0.64; 'here': 0.65; '2012': 0.67; 'offer': 0.72; 'soul': 0.82; 'undoubtedly': 0.84; '4:44': 0.91; 'url:bbc': 0.93
X-Injected-Via-Gmane: http://gmane.org/
To: python-list@python.org
From: Terry Reedy <tjreedy@udel.edu>
Subject: Re: Newbie: Looking for code review on my first Python project.
Date: Tue, 10 Jan 2012 20:50:18 -0500
References: <jeiig6$csj$1@news.albasani.net> <CALwzid=a2eoKQuUYewDyVBvX3sSpxdF0zi08KxURCP2+N1Xo4w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Gmane-NNTP-Posting-Host: pool-74-109-121-73.phlapa.fios.verizon.net
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20111105 Thunderbird/8.0
In-Reply-To: <CALwzid=a2eoKQuUYewDyVBvX3sSpxdF0zi08KxURCP2+N1Xo4w@mail.gmail.com>
X-BeenThere: python-list@python.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: General discussion list for the Python programming language <python-list.python.org>
List-Unsubscribe: <http://mail.python.org/mailman/options/python-list>, <mailto:python-list-request@python.org?subject=unsubscribe>
List-Archive: <http://mail.python.org/pipermail/python-list>
List-Post: <mailto:python-list@python.org>
List-Help: <mailto:python-list-request@python.org?subject=help>
List-Subscribe: <http://mail.python.org/mailman/listinfo/python-list>, <mailto:python-list-request@python.org?subject=subscribe>
Newsgroups: comp.lang.python
Message-ID: <mailman.4622.1326246646.27778.python-list@python.org>
Lines: 24
NNTP-Posting-Host: 2001:888:2000:d::a6
X-Trace: 1326246646 news.xs4all.nl 6957 [2001:888:2000:d::a6]:34505
X-Complaints-To: abuse@xs4all.nl
Xref: x330-a1.tempe.blueboxinc.net comp.lang.python:18796

On 1/10/2012 8:17 PM, Ian Kelly wrote:
> On Tue, Jan 10, 2012 at 4:44 PM, HoneyMonster<someone@someplace.invalid>  wrote:
>> Hi,
>>
>> I'm new to Python and recently completed my first project. I used
>> wxPython with wxGlade to generate the GUI bits.The application seems to
>> work well, but I am entirely self-taught, so have undoubtedly committed a
>> number of howlers in terms of style, design, standards, best practice and
>> so forth.
>>
>> Is there any kind soul here who would be willing to take a look at the
>> code and offer comments?  The code is at:
>> <http://dl.dropbox.com/u/6106778/bbc.py>
>
> Okay, here goes. :-)

Nice review. Though OP used and you wrote about wx, when I get deeper 
into the IDLE code, I will look to see whether tkinter/idle resource 
provide context managers (if not, try to add) and whether idle is using 
them. (I won't be surprised if answers are often no and no.)

-- 
Terry Jan Reedy