Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.python > #18853

Re: Newbie: Looking for code review on my first Python project.

Show all headers | View raw

HoneyMonster於 2012年1月12日星期四UTC+8上午5時09分13秒寫道：
> On Wed, 11 Jan 2012 11:39:48 +0000, HoneyMonster wrote:
> 
> > On Tue, 10 Jan 2012 18:17:48 -0700, Ian Kelly wrote:
> > 
> >> On Tue, Jan 10, 2012 at 4:44 PM, HoneyMonster
> >> <someone@someplace.invalid> wrote:
> >>> Hi,
> >>>
> >>> I'm new to Python and recently completed my first project. I used
> >>> wxPython with wxGlade to generate the GUI bits.The application seems
> >>> to work well, but I am entirely self-taught, so have undoubtedly
> >>> committed a number of howlers in terms of style, design, standards,
> >>> best practice and so forth.
> > < snip constructive and helpful advice >
> > 
> > Very many thanks to Ian and to all who responded. I really appreciate
> > the guidance. Cheers.
> 
> 
> I have taken on board the helpful suggestions offered, and looked though 
> the PEP-8 document which has been mentioned.
> 
> As a result, there are a number of changes to the code. My second attempt 
> is in the same place:
> 
> <http://dl.dropbox.com/u/6106778/bbc.py>
> 
> A couple of points:
> 
> 1) I'm reluctant to try to improve this bit of code:
> -------------------------------------------------------------
>         self.add = wx.MenuItem(self.file, wx.NewId(), "&Add to Queue", 
> "Add a programme to the queue (for download later)", wx.ITEM_NORMAL)
>         self.file.AppendItem(self.add)
> -------------------------------------------------------------
> since it is generated by wxGlade and so will be overwritten.
> 
> 2) I was very unsure about the wx.CallAfter, and suspect that I have put 
> it in the wrong place. It seems to pass off well enough in Linux, but on 
> Windows it appears to prevent the widgets on the splash frame being drawn 
> properly.
> 
> If anyone would be kind enough, further comments would be welcomed.
> 
> Thanks,
> WH

I haven't tried wxGlade for several years. I checked BOA, WxGlade and  Wxpython 
and pygame 4 years ago. Auto code generators in BOA and WxGlade are more helpful
to python programmers.  

One can develop GUI by  python with  Tcl/tk or Qt, too.   
But the license conditions in software packages are not all the same.  

Back to comp.lang.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Newbie: Looking for code review on my first Python project. HoneyMonster <someone@someplace.invalid> - 2012-01-10 23:44 +0000
  Re: Newbie: Looking for code review on my first Python project. Ian Kelly <ian.g.kelly@gmail.com> - 2012-01-10 18:17 -0700
    Re: Newbie: Looking for code review on my first Python project. HoneyMonster <someone@someplace.invalid> - 2012-01-11 11:39 +0000
      Re: Newbie: Looking for code review on my first Python project. HoneyMonster <someone@someplace.invalid> - 2012-01-11 21:09 +0000
        Re: Newbie: Looking for code review on my first Python project. 88888 Dihedral <dihedral88888@googlemail.com> - 2012-01-11 16:24 -0800
  Re: Newbie: Looking for code review on my first Python project. Chris Angelico <rosuav@gmail.com> - 2012-01-11 12:43 +1100
    Re: Newbie: Looking for code review on my first Python project. Ben Finney <ben+python@benfinney.id.au> - 2012-01-11 13:05 +1100
  Re: Newbie: Looking for code review on my first Python project. Terry Reedy <tjreedy@udel.edu> - 2012-01-10 20:50 -0500
  Re: Newbie: Looking for code review on my first Python project. Terry Reedy <tjreedy@udel.edu> - 2012-01-10 22:59 -0500
    Re: Newbie: Looking for code review on my first Python project. Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2012-01-11 04:24 +0000
    Re: Newbie: Looking for code review on my first Python project. Ben Finney <ben+python@benfinney.id.au> - 2012-01-11 16:23 +1100

csiph-web