Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #16143

Re: Policy Change Proposal: Running the upstream test suite

Show all headers | View raw

On Wed, 31 Jul 2024 at 19:01:05 +0500, Andrey Rakhmatullin wrote:
> On Wed, Jul 31, 2024 at 09:46:27AM +0100, Simon McVittie wrote:
> > If we want to run upstream test-suites as autopkgtests, then I think
> > ideally we want the same test coverage as autopkgtest-pkg-python,
> > *and* the same test coverage as autopkgtest-pkg-pybuild, as separate
> > autopkgtest test-cases with different dependencies.
> 
> I always thought the smoke test is redundant if there is the upstream
> tests one.
> What do you think?

I think it is not redundant, because it's a quick way to catch packaging
errors where the python3-foo binary package is missing a mandatory
dependency - which seems to be a somewhat common failure mode, because
the maintainer (who presumably has the Build-Depends installed) will
never notice it by testing on their own system.

For instance in this (hypothetical) package:

    Source: python-foo
    Build-Depends: dh-python, python3-all, python3-bar, ...

    Package: python3-foo
    Depends: ${misc:Depends}, ${python3:Depends}

Suppose python3-foo does an "import bar", therefore there should have
been a "Depends: python3-bar" which is missing here. The smoke test
would detect that.

(I know that ideally python3-bar would be part of the ${python3:Depends},
and with some upstream build systems under some phases of the moon,
it is; but I'm thinking here about the packages where that information
doesn't work or isn't propagated.)

I'm a fan of putting a small amount of effort into automated tests, and
then having running the tests before uploading save you from a class of
Severity: grave bugs forever :-)

> > But I don't think we can easily have that, because the Testsuite field
> > only takes one value.

Actually it seems it's meant to be able to take more than one value, and
the fact that autodep8 doesn't support that appears to be considered a bug.
(#1042717, #1061620, #1077645)

    smcv

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

Policy Change Proposal: Running the upstream test suite Louis-Philippe Véronneau <pollo@debian.org> - 2024-07-29 11:00 +0200
  Re: Policy Change Proposal: Running the upstream test suite PICCA Frederic-Emmanuel <frederic-emmanuel.picca@synchrotron-soleil.fr> - 2024-07-29 11:30 +0200
    Re: Policy Change Proposal: Running the upstream test suite Martin <debacle@debian.org> - 2024-07-29 14:00 +0200
      Re: Policy Change Proposal: Running the upstream test suite PICCA Frederic-Emmanuel <frederic-emmanuel.picca@synchrotron-soleil.fr> - 2024-07-29 15:50 +0200
        Re: Policy Change Proposal: Running the upstream test suite Andrey Rakhmatullin <wrar@debian.org> - 2024-07-29 16:00 +0200
          Re: Policy Change Proposal: Running the upstream test suite PICCA Frederic-Emmanuel <frederic-emmanuel.picca@synchrotron-soleil.fr> - 2024-07-29 17:40 +0200
            Re: Policy Change Proposal: Running the upstream test suite Scott Kitterman <debian@kitterman.com> - 2024-07-29 18:10 +0200
            Re: Policy Change Proposal: Running the upstream test suite Andrey Rakhmatullin <wrar@debian.org> - 2024-07-30 10:40 +0200
              Re: Policy Change Proposal: Running the upstream test suite PICCA Frederic-Emmanuel <frederic-emmanuel.picca@synchrotron-soleil.fr> - 2024-07-30 11:10 +0200
                Re: Policy Change Proposal: Running the upstream test suite Andrey Rakhmatullin <wrar@debian.org> - 2024-07-31 16:20 +0200
              Re: Policy Change Proposal: Running the upstream test suite Julian Gilbey <julian@d-and-j.net> - 2024-07-30 17:00 +0200
                Re: Policy Change Proposal: Running the upstream test suite Andrey Rakhmatullin <wrar@debian.org> - 2024-07-31 16:10 +0200
          Re: Policy Change Proposal: Running the upstream test suite Simon McVittie <smcv@debian.org> - 2024-07-31 10:50 +0200
            Re: Policy Change Proposal: Running the upstream test suite Andrey Rakhmatullin <wrar@debian.org> - 2024-07-31 16:10 +0200
              Re: Policy Change Proposal: Running the upstream test suite Simon McVittie <smcv@debian.org> - 2024-07-31 16:20 +0200
  Re: Policy Change Proposal: Running the upstream test suite Scott Kitterman <debian@kitterman.com> - 2024-07-29 14:10 +0200
    Re: Policy Change Proposal: Running the upstream test suite Simon McVittie <smcv@debian.org> - 2024-07-29 16:40 +0200
    Re: Policy Change Proposal: Running the upstream test suite Julian Gilbey <julian@d-and-j.net> - 2024-07-29 23:50 +0200
    Re: Policy Change Proposal: Running the upstream test suite Louis-Philippe Véronneau <pollo@debian.org> - 2024-07-30 03:00 +0200
      Re: Policy Change Proposal: Running the upstream test suite Scott Kitterman <debian@kitterman.com> - 2024-07-30 04:20 +0200
        Re: Policy Change Proposal: Running the upstream test suite Louis-Philippe Véronneau <pollo@debian.org> - 2024-07-30 04:50 +0200
          Re: Policy Change Proposal: Running the upstream test suite Scott Kitterman <debian@kitterman.com> - 2024-07-30 06:00 +0200
            Re: Policy Change Proposal: Running the upstream test suite Louis-Philippe Véronneau <pollo@debian.org> - 2024-07-30 06:30 +0200
              Re: Policy Change Proposal: Running the upstream test suite Scott Kitterman <debian@kitterman.com> - 2024-07-30 06:50 +0200
                Re: Policy Change Proposal: Running the upstream test suite thomas@goirand.fr - 2024-07-30 09:20 +0200
  Re: Policy Change Proposal: Running the upstream test suite Pierre-Elliott Bécue <peb@debian.org> - 2024-07-29 16:10 +0200
    Re: Policy Change Proposal: Running the upstream test suite Louis-Philippe Véronneau <pollo@debian.org> - 2024-07-30 03:00 +0200
  Re: Policy Change Proposal: Running the upstream test suite Louis-Philippe Véronneau <pollo@debian.org> - 2024-08-15 00:10 +0200
    Re: Policy Change Proposal: Running the upstream test suite Andreas Tille <andreas@an3as.eu> - 2024-08-16 17:00 +0200
    Re: Policy Change Proposal: Running the upstream test suite Pierre-Elliott Bécue <peb@debian.org> - 2024-08-17 00:50 +0200
      Re: Policy Change Proposal: Running the upstream test suite Louis-Philippe Véronneau <pollo@debian.org> - 2024-08-18 23:20 +0200
        Re: Policy Change Proposal: Running the upstream test suite Graham Inggs <ginggs@debian.org> - 2024-08-19 15:40 +0200

csiph-web