Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1742503
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] mkiss: remove redundant check on len being zero |
| Date | 2017-09-30 06:50 +0200 |
| Message-ID | <uvhSW-7Mh-3@gated-at.bofh.it> (permalink) |
| References | <uusno-8uO-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Colin King <colin.king@canonical.com>
Date: Wed, 27 Sep 2017 22:45:13 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The check on len is redundant as it is always greater than 1,
> so just remove it and make the printk less complex.
>
> Detected by CoverityScan, CID#1226729 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] mkiss: remove redundant check on len being zero Colin King <colin.king@canonical.com> - 2017-09-27 23:50 +0200 Re: [PATCH] mkiss: remove redundant check on len being zero David Miller <davem@davemloft.net> - 2017-09-30 06:50 +0200
csiph-web