Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: David Miller Newsgroups: linux.kernel Subject: Re: [PATCH] mkiss: remove redundant check on len being zero Date: Sat, 30 Sep 2017 06:50:02 +0200 Message-ID: References: X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) MIME-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 29 Sep 2017 21:44:56 -0700 (PDT) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 13 Organization: linux.* mail to news gateway X-Original-Cc: stephen@networkplumber.org, johannes.berg@intel.com, ralf@linux-mips.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org X-Original-Date: Sat, 30 Sep 2017 05:44:54 +0100 (WEST) X-Original-Message-ID: <20170930.054454.1056054589514297047.davem@davemloft.net> X-Original-References: <20170927214513.22562-1-colin.king@canonical.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1742503 From: Colin King Date: Wed, 27 Sep 2017 22:45:13 +0100 > From: Colin Ian King > > The check on len is redundant as it is always greater than 1, > so just remove it and make the printk less complex. > > Detected by CoverityScan, CID#1226729 ("Logically dead code") > > Signed-off-by: Colin Ian King Applied, thanks.