Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1742077

Re: [PATCH v2 0/2] mtd: nand: wait for tWHR, and fix the setup_data_interface of Denali

Show all headers | View raw

On Fri, 29 Sep 2017 19:38:38 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

> 1/2 : add NAND_WAIT_TWHR and nand_whr_delay().
>       You can set this new flag if you want nand_command(_lp)
>       to insert tWHR delay where needed.
> 
> 2/2 : Fix Denali setup_data_interface.
>       Boris' suggestion in v1 was a good reminder that
>       made me realize tCCS was missing in the driver.  Fix it now.
> 
> 
> Changes in v2:
>   - Add nand_whr_delay() helper
>     Wait for tWHR only for drivers that explicitly set NAND_WAIT_TWHR flag
>   - newly added
> 
> Masahiro Yamada (2):
>   mtd: nand: wait for tWHR after NAND_CMD_STATUS / NAND_CMD_READID

Hm, I thought you were introducing this to then use it in the denali
driver. Sorry, but I don't want to apply something that nobody needs.
If someone ever complains about a missing delay I'll point him to your
patch, but until then I'll keep the core unchanged.

>   mtd: nand: denali: fix setup_data_interface to meet tCCS delay

This one is valid. I'll queue it to nand/next soon.

Thanks,

Boris

> 
>  drivers/mtd/nand/denali.c    | 10 ++++++++--
>  drivers/mtd/nand/nand_base.c | 21 +++++++++++++++++++--
>  include/linux/mtd/rawnand.h  | 13 ++++++++-----
>  3 files changed, 35 insertions(+), 9 deletions(-)
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/2] mtd: nand: wait for tWHR, and fix the setup_data_interface of Denali Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-29 12:50 +0200
  [PATCH v2 1/2] mtd: nand: wait for tWHR after NAND_CMD_STATUS / NAND_CMD_READID Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-29 12:50 +0200
  Re: [PATCH v2 0/2] mtd: nand: wait for tWHR, and fix the  setup_data_interface of Denali Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-09-29 14:30 +0200
    Re: [PATCH v2 0/2] mtd: nand: wait for tWHR, and fix the  setup_data_interface of Denali Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-29 16:10 +0200
      Re: [PATCH v2 0/2] mtd: nand: wait for tWHR, and fix the  setup_data_interface of Denali Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-09-29 16:30 +0200
    Re: [PATCH v2 0/2] mtd: nand: wait for tWHR, and fix the  setup_data_interface of Denali Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-29 16:40 +0200

csiph-web