Groups > linux.kernel > #1742077

Re: [PATCH v2 0/2] mtd: nand: wait for tWHR, and fix the setup_data_interface of Denali

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 0/2] mtd: nand: wait for tWHR, and fix the setup_data_interface of Denali
Date	Fri, 29 Sep 2017 14:30:01 +0200
Message-ID	<uv2Ax-67j-1@gated-at.bofh.it> (permalink)
References	<uv11L-51L-3@gated-at.bofh.it>
X-Mailer	Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	39
Organization	linux.* mail to news gateway
X-Original-Cc	linux-mtd@lists.infradead.org, Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>, linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>, Brian Norris <computersforpeace@gmail.com>, Richard Weinberger <richard@nod.at>, David Woodhouse <dwmw2@infradead.org>
X-Original-Date	Fri, 29 Sep 2017 14:26:35 +0200
X-Original-Message-ID	<20170929142635.07d55f77@bbrezillon>
X-Original-References	<1506681520-13897-1-git-send-email-yamada.masahiro@socionext.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1742077

Show key headers only | View raw

On Fri, 29 Sep 2017 19:38:38 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

> 1/2 : add NAND_WAIT_TWHR and nand_whr_delay().
>       You can set this new flag if you want nand_command(_lp)
>       to insert tWHR delay where needed.
> 
> 2/2 : Fix Denali setup_data_interface.
>       Boris' suggestion in v1 was a good reminder that
>       made me realize tCCS was missing in the driver.  Fix it now.
> 
> 
> Changes in v2:
>   - Add nand_whr_delay() helper
>     Wait for tWHR only for drivers that explicitly set NAND_WAIT_TWHR flag
>   - newly added
> 
> Masahiro Yamada (2):
>   mtd: nand: wait for tWHR after NAND_CMD_STATUS / NAND_CMD_READID

Hm, I thought you were introducing this to then use it in the denali
driver. Sorry, but I don't want to apply something that nobody needs.
If someone ever complains about a missing delay I'll point him to your
patch, but until then I'll keep the core unchanged.

>   mtd: nand: denali: fix setup_data_interface to meet tCCS delay

This one is valid. I'll queue it to nand/next soon.

Thanks,

Boris

> 
>  drivers/mtd/nand/denali.c    | 10 ++++++++--
>  drivers/mtd/nand/nand_base.c | 21 +++++++++++++++++++--
>  include/linux/mtd/rawnand.h  | 13 ++++++++-----
>  3 files changed, 35 insertions(+), 9 deletions(-)
>

Thread

[PATCH v2 0/2] mtd: nand: wait for tWHR, and fix the setup_data_interface of Denali Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-29 12:50 +0200
  [PATCH v2 1/2] mtd: nand: wait for tWHR after NAND_CMD_STATUS / NAND_CMD_READID Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-29 12:50 +0200
  Re: [PATCH v2 0/2] mtd: nand: wait for tWHR, and fix the  setup_data_interface of Denali Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-09-29 14:30 +0200
    Re: [PATCH v2 0/2] mtd: nand: wait for tWHR, and fix the  setup_data_interface of Denali Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-29 16:10 +0200
      Re: [PATCH v2 0/2] mtd: nand: wait for tWHR, and fix the  setup_data_interface of Denali Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-09-29 16:30 +0200
    Re: [PATCH v2 0/2] mtd: nand: wait for tWHR, and fix the  setup_data_interface of Denali Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-29 16:40 +0200

csiph-web