Re: [Intel-gfx] [PATCH 05/14] i915: Use %pS printk format for direct addresses

From	Daniel Vetter <daniel@ffwll.ch>
Newsgroups	linux.kernel
Subject	Re: [Intel-gfx] [PATCH 05/14] i915: Use %pS printk format for direct addresses
Date	2017-09-27 14:30 +0200
Message-ID	<uujDs-2nV-29@gated-at.bofh.it> (permalink)
References	<umP7r-6KN-1@gated-at.bofh.it> <umP7s-6KN-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 06, 2017 at 10:27:52PM +0200, Helge Deller wrote:
> Use the %pS printk format for printing symbols from direct addresses.
> This is important for the ia64, ppc64 and parisc64 architectures, while on
> other architectures there is no difference between %pS and %pF.
> Fix it for consistency across the kernel.

i915.ko never runs on any of these, but if it helps with keeping things
consistent, why not.

Applied, thanks.
-Daniel

> 
> Signed-off-by: Helge Deller <deller@gmx.de>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: intel-gfx@lists.freedesktop.org
> ---
>  drivers/gpu/drm/i915/intel_breadcrumbs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_breadcrumbs.c b/drivers/gpu/drm/i915/intel_breadcrumbs.c
> index 4e00e5c..29c62d4 100644
> --- a/drivers/gpu/drm/i915/intel_breadcrumbs.c
> +++ b/drivers/gpu/drm/i915/intel_breadcrumbs.c
> @@ -64,7 +64,7 @@ static unsigned long wait_timeout(void)
>  
>  static noinline void missed_breadcrumb(struct intel_engine_cs *engine)
>  {
> -	DRM_DEBUG_DRIVER("%s missed breadcrumb at %pF, irq posted? %s, current seqno=%x, last=%x\n",
> +	DRM_DEBUG_DRIVER("%s missed breadcrumb at %pS, irq posted? %s, current seqno=%x, last=%x\n",
>  			 engine->name, __builtin_return_address(0),
>  			 yesno(test_bit(ENGINE_IRQ_BREADCRUMB,
>  					&engine->irq_posted)),
> -- 
> 2.1.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [Intel-gfx] [PATCH 05/14] i915: Use %pS printk format for direct  addresses Daniel Vetter <daniel@ffwll.ch> - 2017-09-27 14:30 +0200

csiph-web