Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1740674

Re: [PATCH] xfrm: don't call xfrm_policy_cache_flush under xfrm_state_lock

From Florian Westphal <fw@strlen.de>
Newsgroups linux.kernel
Subject Re: [PATCH] xfrm: don't call xfrm_policy_cache_flush under xfrm_state_lock
Date 2017-09-27 14:40 +0200
Message-ID <uujN7-2tn-7@gated-at.bofh.it> (permalink)
References <uujDs-2nV-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Artem Savkov <asavkov@redhat.com> wrote:
> I might be wrong but it doesn't look like xfrm_state_lock is required
> for xfrm_policy_cache_flush and calling it under this lock triggers both
> "sleeping function called from invalid context" and "possible circular
> locking dependency detected" warnings on flush.
> 
> Fixes: ec30d78c14a8 xfrm: add xdst pcpu cache
> Signed-off-by: Artem Savkov <asavkov@redhat.com>

You're right, its not needed (and wrong).

Acked-by: Florian Westphal <fw@strlen.de>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] xfrm: don't call xfrm_policy_cache_flush under xfrm_state_lock Artem Savkov <asavkov@redhat.com> - 2017-09-27 14:30 +0200
  Re: [PATCH] xfrm: don't call xfrm_policy_cache_flush under  xfrm_state_lock Florian Westphal <fw@strlen.de> - 2017-09-27 14:40 +0200
    Re: [PATCH] xfrm: don't call xfrm_policy_cache_flush under  xfrm_state_lock Steffen Klassert <steffen.klassert@secunet.com> - 2017-09-28 13:20 +0200

csiph-web