Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1738763

Re: [PATCH 0/3] This patchset refactors event related functions

Show all headers | View raw

Am 25.09.2017 05:15 schrieb Harinath Nampally:
> Harinath Nampally (3):
> Following 2 patches are for refactor:
>   iio: accel: mma8452: Rename time step look up struct     to generic
>     name as the values are same for all the events.
>   iio: accel: mma8452: Rename read/write event value     callbacks to
>     generic function name.
> Following patch adds new feature:
>   iio: accel: mma8452: Add single pulse/tap event detection     feature
>     for fxls8471.
> 

I guess it's fine for now, but please don't call your patchset "This 
patchset does...".
Just say "Refactor..." or whatever like you do in your patches.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] This patchset refactors event related functions  Harinath Nampally <harinath922@gmail.com> - 2017-09-25 05:20 +0200
  [PATCH 2/3] iio: accel: mma8452: Rename read/write event value callbacks to generic function name. Harinath Nampally <harinath922@gmail.com> - 2017-09-25 05:20 +0200
  [PATCH 1/3] iio: accel: mma8452: Rename time step look up struct to generic name as the values are same for all the events. Harinath Nampally <harinath922@gmail.com> - 2017-09-25 05:20 +0200
  [PATCH 3/3] iio: accel: mma8452: Add single pulse/tap event detection feature for fxls8471. Harinath Nampally <harinath922@gmail.com> - 2017-09-25 05:20 +0200
    Re: [PATCH 3/3] iio: accel: mma8452: Add single pulse/tap event  detection feature for fxls8471. Martin Kepplinger <martink@posteo.de> - 2017-09-25 08:40 +0200
  Re: [PATCH 0/3] This patchset refactors event related functions Martin Kepplinger <martink@posteo.de> - 2017-09-25 08:30 +0200

csiph-web