Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1738191
| From | Johannes Berg <johannes@sipsolutions.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RESEND] Re: usb/net/p54: trying to register non-static key in p54_unregister_leds |
| Date | 2017-09-24 16:20 +0200 |
| Message-ID | <utfVf-1hT-5@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <urTk6-7sy-17@gated-at.bofh.it> <useox-4rm-11@gated-at.bofh.it> <usYro-7bY-13@gated-at.bofh.it> <utfVf-1hT-7@gated-at.bofh.it> <usYro-7bY-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, 2017-09-23 at 21:37 +0200, Christian Lamparter wrote: > But this also begs the question: Is this really working then? > From what I can tell, if CONFIG_LOCKDEP is not set then there's no > BUG no WARN, no other splat or any other odd system behaviour. Does > [cancel | flush]_[delayed_]work[_sync] really "just work" by > *accident*, as long the delayed_work | work_struct is zeroed out? It looks like it does, but I'm not sure it's not more or less by accident. Look at get_work_pool() for example, it might actually return non-NULL in this case, and then in start_flush_work() you'll probably fall into one of the few "already_gone" cases. > And should it work in the future as well? I guess it's not really guaranteed, the API doesn't state anything to that effect. Not that I'm looking forward to a new workqueue rewrite ;) johannes
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
usb/net/p54: trying to register non-static key in p54_unregister_leds Andrey Konovalov <andreyknvl@google.com> - 2017-09-20 20:40 +0200
Re: usb/net/p54: trying to register non-static key in p54_unregister_leds Christian Lamparter <chunkeey@googlemail.com> - 2017-09-20 21:30 +0200
Re: usb/net/p54: trying to register non-static key in p54_unregister_leds Johannes Berg <johannes@sipsolutions.net> - 2017-09-20 22:00 +0200
Re: usb/net/p54: trying to register non-static key in p54_unregister_leds Andrey Konovalov <andreyknvl@google.com> - 2017-09-21 20:30 +0200
[RESEND] Re: usb/net/p54: trying to register non-static key in p54_unregister_leds Christian Lamparter <chunkeey@googlemail.com> - 2017-09-23 21:40 +0200
Re: [RESEND] Re: usb/net/p54: trying to register non-static key in p54_unregister_leds Johannes Berg <johannes@sipsolutions.net> - 2017-09-24 16:20 +0200
Re: [RESEND] Re: usb/net/p54: trying to register non-static key in p54_unregister_leds Andrey Konovalov <andreyknvl@google.com> - 2017-09-26 17:10 +0200
csiph-web