Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1738190
| From | Marek Vasut <marek.vasut@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM support |
| Date | 2017-09-24 16:00 +0200 |
| Message-ID | <utfBU-Wx-17@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <utcXo-7Yz-7@gated-at.bofh.it> <ute38-as-7@gated-at.bofh.it> <uteZc-JV-3@gated-at.bofh.it> <uteZc-JV-1@gated-at.bofh.it> <utf8R-N4-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 09/24/2017 03:27 PM, Vignesh R wrote: > > > On 9/24/2017 6:42 PM, Marek Vasut wrote: >> On 09/24/2017 03:08 PM, Vignesh R wrote: >>> >>> >>> On 9/24/2017 5:31 PM, Marek Vasut wrote: >>>> On 09/24/2017 12:59 PM, Vignesh R wrote: >>>>> Add pm_runtime* calls to cadence-quadspi driver. This is required to >>>>> switch on QSPI power domain on TI 66AK2G SoC during probe. >>>>> >>>>> Signed-off-by: Vignesh R <vigneshr@ti.com> >>>> >>>> Are you planning to add some more fine-grained PM control later? >>> >>> Yes, I will need to add fine-grained PM control at some point. But, for >>> now SoC does not really support low power mode or runtime power saving >>> option. >>> The fact that driver still uses clk_prepare_*() calls to enable/disable >>> clocks instead of pm_*() calls makes it a bit tricky though. >>> >>> Just figured out I forgot to add cleanup code in error handling path of >>> probe(). Will fix that and send a v4. >> >> OK, fine. Cleanups are welcome. The SoCFPGA doesn't do much runtime PM >> either, so it's fine for now. >> > > Ok thanks! Do you know if pm_runtime_get_sync() can enable clocks for > QSPI on SoCFPGA or if clk_prepare_enable() is needed? Just trying to see > if its possible to get rid of clk_*() calls in favor of pm_*() calls. Not of the top of my head, sorry. +CC Matthew, he should know. -- Best regards, Marek Vasut
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM support Vignesh R <vigneshr@ti.com> - 2017-09-24 13:10 +0200
Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM support Marek Vasut <marek.vasut@gmail.com> - 2017-09-24 14:20 +0200
Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM support Marek Vasut <marek.vasut@gmail.com> - 2017-09-24 15:20 +0200
Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM support Vignesh R <vigneshr@ti.com> - 2017-09-24 15:30 +0200
Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM support Marek Vasut <marek.vasut@gmail.com> - 2017-09-24 16:00 +0200
Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM support matthew.gerlach@linux.intel.com - 2017-09-26 00:50 +0200
Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM support Marek Vasut <marek.vasut@gmail.com> - 2017-09-26 02:00 +0200
Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM support Vignesh R <vigneshr@ti.com> - 2017-09-24 15:20 +0200
csiph-web