Re: [PATCH v2] s390/char: Fix cdev_add usage

From	Heiko Carstens <heiko.carstens@de.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] s390/char: Fix cdev_add usage
Date	2017-09-18 16:30 +0200
Message-ID	<ur5dE-7ro-31@gated-at.bofh.it> (permalink)
References	<ur0QH-4nB-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Sep 18, 2017 at 11:13:13AM +0200, Jean Delvare wrote:
> Function cdev_add does set cdev->dev, so there is no point in setting
> it prior to calling this function.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
> Untested. Changes since v1 (2016-07-13):
>  * Improved description
>  * Added a few blank lines to make the code more readable
> 
>  drivers/s390/char/tape_class.c |    3 +--
>  drivers/s390/char/vmlogrdr.c   |    4 ++--
>  drivers/s390/char/vmur.c       |    4 ++--
>  3 files changed, 5 insertions(+), 6 deletions(-)

Applied, however without the extra blank lines ;)
Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] s390/char: Fix cdev_add usage Jean Delvare <jdelvare@suse.de> - 2017-09-18 11:50 +0200
  Re: [PATCH v2] s390/char: Fix cdev_add usage Heiko Carstens <heiko.carstens@de.ibm.com> - 2017-09-18 16:30 +0200

csiph-web