Re: [PATCH v2] s390/char: Fix cdev_add usage

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Heiko Carstens <heiko.carstens@de.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] s390/char: Fix cdev_add usage
Date	Mon, 18 Sep 2017 16:30:02 +0200
Message-ID	<ur5dE-7ro-31@gated-at.bofh.it> (permalink)
References	<ur0QH-4nB-37@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
X-Tm-As-Gconf	00
X-Cbid	17091814-0040-0000-0000-000003DACC1D
X-Ibm-Av-Detection	SAVI=unused REMOTE=unused XFE=unused
X-Cbparentid	17091814-0041-0000-0000-000025DBF80A
X-Proofpoint-Virus-Version	vendor=fsecure engine=2.50.10432:,, definitions=2017-09-18_04:,, signatures=0
X-Proofpoint-Spam-Details	rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1709180207
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	19
Organization	linux.* mail to news gateway
X-Original-Cc	linux-s390@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, Martin Schwidefsky <schwidefsky@de.ibm.com>
X-Original-Date	Mon, 18 Sep 2017 16:22:40 +0200
X-Original-Message-ID	<20170918142240.GF4649@osiris>
X-Original-References	<20170918111313.1fc7126e@endymion>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1734184

Show key headers only | View raw

On Mon, Sep 18, 2017 at 11:13:13AM +0200, Jean Delvare wrote:
> Function cdev_add does set cdev->dev, so there is no point in setting
> it prior to calling this function.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
> Untested. Changes since v1 (2016-07-13):
>  * Improved description
>  * Added a few blank lines to make the code more readable
> 
>  drivers/s390/char/tape_class.c |    3 +--
>  drivers/s390/char/vmlogrdr.c   |    4 ++--
>  drivers/s390/char/vmur.c       |    4 ++--
>  3 files changed, 5 insertions(+), 6 deletions(-)

Applied, however without the extra blank lines ;)
Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] s390/char: Fix cdev_add usage Jean Delvare <jdelvare@suse.de> - 2017-09-18 11:50 +0200
  Re: [PATCH v2] s390/char: Fix cdev_add usage Heiko Carstens <heiko.carstens@de.ibm.com> - 2017-09-18 16:30 +0200

csiph-web