Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi

From	jeffy <jeffy.chen@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi
Date	2017-09-18 13:30 +0200
Message-ID	<ur2pr-5Fg-3@gated-at.bofh.it> (permalink)
References	<umyJk-3n5-1@gated-at.bofh.it> <upjE5-1RR-1@gated-at.bofh.it> <uqT2N-7vl-3@gated-at.bofh.it> <ur0GZ-4j6-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Heiko,

Thanks for your reply.

On 09/18/2017 05:30 PM, Heiko Stuebner wrote:
>>>> > >>
>>>> > >>-- compatible : "realtek,rt5514".
>>>> > >>+- compatible : "realtek,rt5514" or "realtek,rt5514", "realtek,rt5514-i2c".
>>> > >
>>> > >There's no need for the -spi or -i2c compatibles. This is implied by
>>> > >being a child of those controllers.
>> >heiko mentioned i should add it in the binding in:
>> >https://patchwork.kernel.org/patch/9918987/
> If you add a new compatible you need to add it to the binding. I think what
> Rob means is, that both the i2c and spi side can have the_same_
> compatible without the -i2c or -spi, as you can check wether they are
> children of either a spi or i2c controller in the code itself.
>
ok, got it.

i sent a new patch to check the bus_type instead :)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for  rt5514-spi Rob Herring <robh@kernel.org> - 2017-09-13 19:30 +0200
  Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for  rt5514-spi jeffy <jeffy.chen@rock-chips.com> - 2017-09-18 03:30 +0200
    Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi Heiko Stuebner <heiko@sntech.de> - 2017-09-18 11:40 +0200
      Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for  rt5514-spi jeffy <jeffy.chen@rock-chips.com> - 2017-09-18 13:30 +0200

csiph-web