Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1731734 > unrolled thread
| Started by | Rob Herring <robh@kernel.org> |
|---|---|
| First post | 2017-09-13 19:30 +0200 |
| Last post | 2017-09-18 13:30 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi Rob Herring <robh@kernel.org> - 2017-09-13 19:30 +0200
Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi jeffy <jeffy.chen@rock-chips.com> - 2017-09-18 03:30 +0200
Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi Heiko Stuebner <heiko@sntech.de> - 2017-09-18 11:40 +0200
Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi jeffy <jeffy.chen@rock-chips.com> - 2017-09-18 13:30 +0200
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2017-09-13 19:30 +0200 |
| Subject | Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi |
| Message-ID | <upjE5-1RR-1@gated-at.bofh.it> |
On Wed, Sep 06, 2017 at 10:50:09AM +0800, Jeffy Chen wrote:
> Add devicetree bindings documentation file for rt5514 spi dsp codec.
>
> Also update rt5514 i2c dt-binding's compatible to distinguish it from
> rt5514 spi.
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> ---
>
> Changes in v9:
> Address comments from Brian.
>
> .../devicetree/bindings/sound/rt5514-spi.txt | 29 ++++++++++++++++++++++
> Documentation/devicetree/bindings/sound/rt5514.txt | 4 +--
> 2 files changed, 31 insertions(+), 2 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sound/rt5514-spi.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/rt5514-spi.txt b/Documentation/devicetree/bindings/sound/rt5514-spi.txt
> new file mode 100644
> index 000000000000..7911d1adbd29
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/rt5514-spi.txt
> @@ -0,0 +1,29 @@
> +RT5514 SPI audio CODEC
> +
> +This device supports SPI only.
> +
> +Required properties:
> +
> +- compatible : "realtek,rt5514" or "realtek,rt5514", "realtek,rt5514-spi".
> +
> +- reg : The SPI address of the device.
See below.
> +
> +Optional properties:
> +
> +- interrupt-parent: Should be the phandle for the interrupt controller
> +- interrupts: The interrupt number to the cpu. The interrupt specifier format
> + depends on the interrupt controller.
> +
> +Example:
> +
> +codec: rt5514-spi@0 {
> + compatible = "realtek,rt5514", "realtek,rt5514-spi";
> + reg = <0>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&mic_int>;
> +
> + interrupt-parent = <&gpio1>;
> + interrupts = <13 IRQ_TYPE_LEVEL_HIGH>;
> + wakeup-source;
This needs to be documented too.
> +};
> diff --git a/Documentation/devicetree/bindings/sound/rt5514.txt b/Documentation/devicetree/bindings/sound/rt5514.txt
> index 929ca6756b02..841a1159e234 100644
> --- a/Documentation/devicetree/bindings/sound/rt5514.txt
> +++ b/Documentation/devicetree/bindings/sound/rt5514.txt
> @@ -4,7 +4,7 @@ This device supports I2C only.
SPI support should be added to this document.
>
> Required properties:
>
> -- compatible : "realtek,rt5514".
> +- compatible : "realtek,rt5514" or "realtek,rt5514", "realtek,rt5514-i2c".
There's no need for the -spi or -i2c compatibles. This is implied by
being a child of those controllers.
> - reg : The I2C address of the device.
>
> @@ -28,6 +28,6 @@ Pins on the device (for linking into audio routes) for RT5514:
> Example:
>
> codec: rt5514@57 {
> - compatible = "realtek,rt5514";
> + compatible = "realtek,rt5514", "realtek,rt5514-i2c";
> reg = <0x57>;
> };
> --
> 2.11.0
>
>
[toc] | [next] | [standalone]
| From | jeffy <jeffy.chen@rock-chips.com> |
|---|---|
| Date | 2017-09-18 03:30 +0200 |
| Message-ID | <uqT2N-7vl-3@gated-at.bofh.it> |
| In reply to | #1731734 |
Hi Rob, Thanks for your reply. On 09/14/2017 01:24 AM, Rob Herring wrote: > On Wed, Sep 06, 2017 at 10:50:09AM +0800, Jeffy Chen wrote: >> diff --git a/Documentation/devicetree/bindings/sound/rt5514.txt b/Documentation/devicetree/bindings/sound/rt5514.txt >> index 929ca6756b02..841a1159e234 100644 >> --- a/Documentation/devicetree/bindings/sound/rt5514.txt >> +++ b/Documentation/devicetree/bindings/sound/rt5514.txt >> @@ -4,7 +4,7 @@ This device supports I2C only. > > SPI support should be added to this document. ok, will do. > >> >> Required properties: >> >> -- compatible : "realtek,rt5514". >> +- compatible : "realtek,rt5514" or "realtek,rt5514", "realtek,rt5514-i2c". > > There's no need for the -spi or -i2c compatibles. This is implied by > being a child of those controllers. heiko mentioned i should add it in the binding in: https://patchwork.kernel.org/patch/9918987/
[toc] | [prev] | [next] | [standalone]
| From | Heiko Stuebner <heiko@sntech.de> |
|---|---|
| Date | 2017-09-18 11:40 +0200 |
| Subject | Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi |
| Message-ID | <ur0GZ-4j6-3@gated-at.bofh.it> |
| In reply to | #1733598 |
Hi Jeffy, Am Montag, 18. September 2017, 09:22:21 CEST schrieb jeffy: > On 09/14/2017 01:24 AM, Rob Herring wrote: > > On Wed, Sep 06, 2017 at 10:50:09AM +0800, Jeffy Chen wrote: > >> diff --git a/Documentation/devicetree/bindings/sound/rt5514.txt b/Documentation/devicetree/bindings/sound/rt5514.txt > >> index 929ca6756b02..841a1159e234 100644 > >> --- a/Documentation/devicetree/bindings/sound/rt5514.txt > >> +++ b/Documentation/devicetree/bindings/sound/rt5514.txt > >> @@ -4,7 +4,7 @@ This device supports I2C only. > > > > SPI support should be added to this document. > ok, will do. > > > >> > >> Required properties: > >> > >> -- compatible : "realtek,rt5514". > >> +- compatible : "realtek,rt5514" or "realtek,rt5514", "realtek,rt5514-i2c". > > > > There's no need for the -spi or -i2c compatibles. This is implied by > > being a child of those controllers. > heiko mentioned i should add it in the binding in: > https://patchwork.kernel.org/patch/9918987/ If you add a new compatible you need to add it to the binding. I think what Rob means is, that both the i2c and spi side can have the _same_ compatible without the -i2c or -spi, as you can check wether they are children of either a spi or i2c controller in the code itself. Heiko
[toc] | [prev] | [next] | [standalone]
| From | jeffy <jeffy.chen@rock-chips.com> |
|---|---|
| Date | 2017-09-18 13:30 +0200 |
| Message-ID | <ur2pr-5Fg-3@gated-at.bofh.it> |
| In reply to | #1733902 |
Hi Heiko, Thanks for your reply. On 09/18/2017 05:30 PM, Heiko Stuebner wrote: >>>> > >> >>>> > >>-- compatible : "realtek,rt5514". >>>> > >>+- compatible : "realtek,rt5514" or "realtek,rt5514", "realtek,rt5514-i2c". >>> > > >>> > >There's no need for the -spi or -i2c compatibles. This is implied by >>> > >being a child of those controllers. >> >heiko mentioned i should add it in the binding in: >> >https://patchwork.kernel.org/patch/9918987/ > If you add a new compatible you need to add it to the binding. I think what > Rob means is, that both the i2c and spi side can have the_same_ > compatible without the -i2c or -spi, as you can check wether they are > children of either a spi or i2c controller in the code itself. > ok, got it. i sent a new patch to check the bus_type instead :)
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web