Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1732743

Re: + include-linux-sched-mmh-uninline-mmdrop_async-etc.patch added to -mm tree

Show all headers | View raw

On Fri 15-09-17 09:07:31, Michal Hocko wrote:
> On Thu 14-09-17 13:19:38, Andrew Morton wrote:
> > From: Andrew Morton <akpm@linux-foundation.org>
> > Subject: include/linux/sched/mm.h: uninline mmdrop_async(), etc
> > 
> > mmdrop_async() is only used in fork.c.  Move that and its support
> > functions into fork.c, uninline it all.
> 
> Is this really an improvement? Why do we want to discourage more code
> paths to use mmdrop_async? It sounds like a useful api and it has been
> removed only because it lost its own user in oom code. Now that we have
> a user I would just keep it where it was before.

Dohh, I have mixed mmput_async with mmdrop_async. Anyway I still think
that this is universal enough to have it in a header rather than hiding
it in fork.c
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: + include-linux-sched-mmh-uninline-mmdrop_async-etc.patch added  to -mm tree Michal Hocko <mhocko@kernel.org> - 2017-09-15 09:10 +0200
  Re: + include-linux-sched-mmh-uninline-mmdrop_async-etc.patch added  to -mm tree Michal Hocko <mhocko@kernel.org> - 2017-09-15 09:20 +0200
    Re: + include-linux-sched-mmh-uninline-mmdrop_async-etc.patch added  to -mm tree Andrew Morton <akpm@linux-foundation.org> - 2017-09-15 20:10 +0200
      Re: + include-linux-sched-mmh-uninline-mmdrop_async-etc.patch added  to -mm tree Michal Hocko <mhocko@kernel.org> - 2017-09-18 08:10 +0200

csiph-web