Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1728492

Re: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings

Show all headers | View raw

On Thu, Sep 7, 2017 at 2:40 PM, gaurav jindal
<gauravjindal1104@gmail.com> wrote:
> this patch fixes the below checkpatch errors and warnings in
> drivers/cpuidle/cpuidle.c
>
> WARNING: line over 80 characters
> #311: FILE: drivers/cpuidle/cpuidle.c:311:
> +               /* Make sure all changes finished before we switch to new idle */
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #343: FILE: drivers/cpuidle/cpuidle.c:343:
> +EXPORT_SYMBOL_GPL(cpuidle_pause_and_lock);
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #354: FILE: drivers/cpuidle/cpuidle.c:354:
> +EXPORT_SYMBOL_GPL(cpuidle_resume_and_unlock);
>
> ERROR: do not use assignment in if condition
> #402: FILE: drivers/cpuidle/cpuidle.c:402:
> +       if (cpuidle_curr_governor->enable &&
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #419: FILE: drivers/cpuidle/cpuidle.c:419:
> +EXPORT_SYMBOL_GPL(cpuidle_enable_device);
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #447: FILE: drivers/cpuidle/cpuidle.c:447:
> +EXPORT_SYMBOL_GPL(cpuidle_disable_device);
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #537: FILE: drivers/cpuidle/cpuidle.c:537:
> +EXPORT_SYMBOL_GPL(cpuidle_register_device);
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #561: FILE: drivers/cpuidle/cpuidle.c:561:
> +EXPORT_SYMBOL_GPL(cpuidle_unregister_device);
>
> Signed-off-by:gaurav jindal<gauravjindal1104@gmail.com>
>
> ---
>
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> index 60bb64f..a42148e 100644
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -308,7 +308,10 @@ void cpuidle_reflect(struct cpuidle_device *dev, int index)
>  void cpuidle_install_idle_handler(void)
>  {
>         if (enabled_devices) {
> -               /* Make sure all changes finished before we switch to new idle */
> +               /*
> +                * Make sure all changes finished before we switch to
> +                * new idle
> +                */
>                 smp_wmb();
>                 initialized = 1;
>         }

Don't do this.

The rest is fine by me.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] drivers: cpuidle: Fix checkpatch error and warnings gaurav jindal <gauravjindal1104@gmail.com> - 2017-09-07 12:30 +0200
  Re: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings Joe Perches <joe@perches.com> - 2017-09-07 12:40 +0200
    Re: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings gaurav jindal <gauravjindal1104@gmail.com> - 2017-09-07 14:50 +0200
      Re: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings "Rafael J. Wysocki" <rafael@kernel.org> - 2017-09-08 01:20 +0200
        Re: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings gaurav jindal <gauravjindal1104@gmail.com> - 2017-09-08 15:40 +0200

csiph-web