Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1728131

Re: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings

Show all headers | View raw

On Thu, 2017-09-07 at 15:53 +0530, gaurav jindal wrote:
> This patch fixes the below checkpatch errors and warnings in
> drivers/cpuidle/cpuidle.c

If you are going to propose a checkpatch only patch,
please run your proposed patch through checkpatch.

> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
[]
> 
> @@ -399,9 +400,12 @@ int cpuidle_enable_device(struct cpuidle_device *dev)
>  	if (ret)
>  		return ret;
>  
> -	if (cpuidle_curr_governor->enable &&
> -	    (ret = cpuidle_curr_governor->enable(drv, dev)))
> -		goto fail_sysfs;
> +	if (cpuidle_curr_governor->enable) {
> +
> +		ret = cpuidle_curr_governor->enable(drv, dev);
> +		if (ret)
> +			goto fail_sysfs;
> +	}

checkpatch should complain here about unnecessary
blank line after open brace

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] drivers: cpuidle: Fix checkpatch error and warnings gaurav jindal <gauravjindal1104@gmail.com> - 2017-09-07 12:30 +0200
  Re: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings Joe Perches <joe@perches.com> - 2017-09-07 12:40 +0200
    Re: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings gaurav jindal <gauravjindal1104@gmail.com> - 2017-09-07 14:50 +0200
      Re: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings "Rafael J. Wysocki" <rafael@kernel.org> - 2017-09-08 01:20 +0200
        Re: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings gaurav jindal <gauravjindal1104@gmail.com> - 2017-09-08 15:40 +0200

csiph-web