Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label
Date	2017-09-07 11:50 +0200
Message-ID	<un1BD-6At-3@gated-at.bofh.it> (permalink)
References	<umQdc-7qi-3@gated-at.bofh.it> <umQmR-7tQ-3@gated-at.bofh.it> <un1BD-6At-1@gated-at.bofh.it> <un1BD-6At-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Ingo Molnar <mingo@kernel.org> wrote:

> 
> * Borislav Petkov <bp@alien8.de> wrote:
> 
> > On Wed, Sep 06, 2017 at 02:36:46PM -0700, Andy Lutomirski wrote:
> > > The only user was the 64-bit opportunistic SYSRET failure path, and
> > > that path didn't really need it.  This change makes the
> > > opportunistic SYSRET code a bit more straightforward and gets rid of
> > > the label.
> > > 
> > > Signed-off-by: Andy Lutomirski <luto@kernel.org>
> > > ---
> > >  arch/x86/entry/entry_64.S | 5 ++---
> > >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > Btw, you need to refresh your stuff because of those UNWIND_HINT_EMPTY
> > things. I get:
> > 
> > checking file arch/x86/entry/entry_64.S
> > Hunk #1 succeeded at 245 (offset 5 lines).
> > Hunk #2 FAILED at 308.
> > Hunk #3 succeeded at 637 (offset 88 lines).
> > 1 out of 3 hunks FAILED
> > 
> > Otherwise
> > 
> > Reviewed-by: Borislav Petkov <bp@suse.de>
> 
> I'd suggest tip:master or upstream 24e700e291d5 as a post-merge-window base for 
> x86 bits.

Actually, scratch that, 1c9fe4409ce3 is probably the best base, it includes the 
PCID fixes. Haven't had much time to test that base though.

Thanks,

	Ingo

Thread

[RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label Andy Lutomirski <luto@kernel.org> - 2017-09-06 23:50 +0200
  Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label Borislav Petkov <bp@alien8.de> - 2017-09-07 11:50 +0200
    Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label Ingo Molnar <mingo@kernel.org> - 2017-09-07 11:50 +0200
      Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label Borislav Petkov <bp@alien8.de> - 2017-09-07 12:00 +0200
        Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label Ingo Molnar <mingo@kernel.org> - 2017-09-07 12:30 +0200
    Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label Ingo Molnar <mingo@kernel.org> - 2017-09-07 11:50 +0200

csiph-web