Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1728092

Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label

From Borislav Petkov <bp@alien8.de>
Newsgroups linux.kernel
Subject Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label
Date 2017-09-07 11:50 +0200
Message-ID <un1BD-6At-1@gated-at.bofh.it> (permalink)
References <umQdc-7qi-3@gated-at.bofh.it> <umQmR-7tQ-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Sep 06, 2017 at 02:36:46PM -0700, Andy Lutomirski wrote:
> The only user was the 64-bit opportunistic SYSRET failure path, and
> that path didn't really need it.  This change makes the
> opportunistic SYSRET code a bit more straightforward and gets rid of
> the label.
> 
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
>  arch/x86/entry/entry_64.S | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Btw, you need to refresh your stuff because of those UNWIND_HINT_EMPTY
things. I get:

checking file arch/x86/entry/entry_64.S
Hunk #1 succeeded at 245 (offset 5 lines).
Hunk #2 FAILED at 308.
Hunk #3 succeeded at 637 (offset 88 lines).
1 out of 3 hunks FAILED

Otherwise

Reviewed-by: Borislav Petkov <bp@suse.de>

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label Andy Lutomirski <luto@kernel.org> - 2017-09-06 23:50 +0200
  Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label Borislav Petkov <bp@alien8.de> - 2017-09-07 11:50 +0200
    Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label Ingo Molnar <mingo@kernel.org> - 2017-09-07 11:50 +0200
      Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label Borislav Petkov <bp@alien8.de> - 2017-09-07 12:00 +0200
        Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label Ingo Molnar <mingo@kernel.org> - 2017-09-07 12:30 +0200
    Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label Ingo Molnar <mingo@kernel.org> - 2017-09-07 11:50 +0200

csiph-web