Re: [PATCH] acpi: apei: call into AER handling regardless of severity

From	Borislav Petkov <bp@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] acpi: apei: call into AER handling regardless of severity
Date	2017-08-30 19:10 +0200
Message-ID	<ukeF3-2E4-1@gated-at.bofh.it> (permalink)
References	(4 earlier) <ujXkS-5k-13@gated-at.bofh.it> <uk8gi-733-3@gated-at.bofh.it> <ukbQS-R3-5@gated-at.bofh.it> <ukcWB-1xz-15@gated-at.bofh.it> <ukdfX-1Et-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 30, 2017 at 11:31:06AM -0400, Sinan Kaya wrote:
> I see. We should probably try to do something only if GHES_SEV_CORRECTED or
> GHES_SEV_RECOVERABLE.
> 
> If somebody wants to crash the system with GHES_SEV_PANIC, there is no point
> in doing additional work.

Makes sense.

Whatever we do, I'd like to have this all nicely documented *why* we're
doing the recovery policy we're doing.

> Sounds good. Do you still want to do PCIe recovery in the case of
> GHES_SEV_PANIC or if some FW returns GHES_SEV_NO?

So I read GHES_SEV_PANIC as: we should panic and stop any processing
whatsoever ASAP in order to avoid further error propagation. So doing
recovery there might *actually* be a bad idea.

GHES_SEV_NO would map to AER_CORRECTABLE and I think that would mean,
print the error to let the user know but no need to recover because no
harm was done.

I *think*.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--

Thread

[PATCH] acpi: apei: call into AER handling regardless of severity Tyler Baicar <tbaicar@codeaurora.org> - 2017-08-28 19:20 +0200
  Re: [PATCH] acpi: apei: call into AER handling regardless of severity "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-08-28 23:10 +0200
  Re: [PATCH] acpi: apei: call into AER handling regardless of severity Borislav Petkov <bp@suse.de> - 2017-08-29 10:30 +0200
    Re: [PATCH] acpi: apei: call into AER handling regardless of severity "Baicar, Tyler" <tbaicar@codeaurora.org> - 2017-08-29 23:30 +0200
      Re: [PATCH] acpi: apei: call into AER handling regardless of severity Borislav Petkov <bp@suse.de> - 2017-08-30 00:20 +0200
        Re: [PATCH] acpi: apei: call into AER handling regardless of severity Sinan Kaya <okaya@codeaurora.org> - 2017-08-30 00:40 +0200
          Re: [PATCH] acpi: apei: call into AER handling regardless of severity Borislav Petkov <bp@suse.de> - 2017-08-30 12:20 +0200
            Re: [PATCH] acpi: apei: call into AER handling regardless of severity Sinan Kaya <okaya@codeaurora.org> - 2017-08-30 16:10 +0200
              Re: [PATCH] acpi: apei: call into AER handling regardless of severity Borislav Petkov <bp@suse.de> - 2017-08-30 17:20 +0200
                Re: [PATCH] acpi: apei: call into AER handling regardless of severity Sinan Kaya <okaya@codeaurora.org> - 2017-08-30 17:40 +0200
                Re: [PATCH] acpi: apei: call into AER handling regardless of severity "Baicar, Tyler" <tbaicar@codeaurora.org> - 2017-08-30 17:50 +0200
                Re: [PATCH] acpi: apei: call into AER handling regardless of severity Borislav Petkov <bp@suse.de> - 2017-08-30 19:20 +0200
                Re: [PATCH] acpi: apei: call into AER handling regardless of severity "Baicar, Tyler" <tbaicar@codeaurora.org> - 2017-08-30 20:10 +0200
                Re: [PATCH] acpi: apei: call into AER handling regardless of severity Borislav Petkov <bp@suse.de> - 2017-08-30 19:10 +0200
        RE: [PATCH] acpi: apei: call into AER handling regardless of  severity "Luck, Tony" <tony.luck@intel.com> - 2017-08-30 01:10 +0200

csiph-web