Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1721961

Re: [PATCH] acpi: apei: call into AER handling regardless of severity

Show all headers | View raw

On Monday, August 28, 2017 7:11:54 PM CEST Tyler Baicar wrote:
> Currently the GHES code only calls into the AER driver for
> recoverable type errors. This is incorrect because errors of
> other severities do not get logged by the AER driver and do not
> get exposed to user space via the AER trace event. So, call
> into the AER driver for PCIe errors regardless of the severity.
> 
> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org>

Boris?

> ---
>  drivers/acpi/apei/ghes.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index d661d45..5cab238 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -489,9 +489,7 @@ static void ghes_do_proc(struct ghes *ghes,
>  		else if (guid_equal(sec_type, &CPER_SEC_PCIE)) {
>  			struct cper_sec_pcie *pcie_err = acpi_hest_get_payload(gdata);
>  
> -			if (sev == GHES_SEV_RECOVERABLE &&
> -			    sec_sev == GHES_SEV_RECOVERABLE &&
> -			    pcie_err->validation_bits & CPER_PCIE_VALID_DEVICE_ID &&
> +			if (pcie_err->validation_bits & CPER_PCIE_VALID_DEVICE_ID &&
>  			    pcie_err->validation_bits & CPER_PCIE_VALID_AER_INFO) {
>  				unsigned int devfn;
>  				int aer_severity;
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] acpi: apei: call into AER handling regardless of severity Tyler Baicar <tbaicar@codeaurora.org> - 2017-08-28 19:20 +0200
  Re: [PATCH] acpi: apei: call into AER handling regardless of severity "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-08-28 23:10 +0200
  Re: [PATCH] acpi: apei: call into AER handling regardless of severity Borislav Petkov <bp@suse.de> - 2017-08-29 10:30 +0200
    Re: [PATCH] acpi: apei: call into AER handling regardless of severity "Baicar, Tyler" <tbaicar@codeaurora.org> - 2017-08-29 23:30 +0200
      Re: [PATCH] acpi: apei: call into AER handling regardless of severity Borislav Petkov <bp@suse.de> - 2017-08-30 00:20 +0200
        Re: [PATCH] acpi: apei: call into AER handling regardless of severity Sinan Kaya <okaya@codeaurora.org> - 2017-08-30 00:40 +0200
          Re: [PATCH] acpi: apei: call into AER handling regardless of severity Borislav Petkov <bp@suse.de> - 2017-08-30 12:20 +0200
            Re: [PATCH] acpi: apei: call into AER handling regardless of severity Sinan Kaya <okaya@codeaurora.org> - 2017-08-30 16:10 +0200
              Re: [PATCH] acpi: apei: call into AER handling regardless of severity Borislav Petkov <bp@suse.de> - 2017-08-30 17:20 +0200
                Re: [PATCH] acpi: apei: call into AER handling regardless of severity Sinan Kaya <okaya@codeaurora.org> - 2017-08-30 17:40 +0200
                Re: [PATCH] acpi: apei: call into AER handling regardless of severity "Baicar, Tyler" <tbaicar@codeaurora.org> - 2017-08-30 17:50 +0200
                Re: [PATCH] acpi: apei: call into AER handling regardless of severity Borislav Petkov <bp@suse.de> - 2017-08-30 19:20 +0200
                Re: [PATCH] acpi: apei: call into AER handling regardless of severity "Baicar, Tyler" <tbaicar@codeaurora.org> - 2017-08-30 20:10 +0200
                Re: [PATCH] acpi: apei: call into AER handling regardless of severity Borislav Petkov <bp@suse.de> - 2017-08-30 19:10 +0200
        RE: [PATCH] acpi: apei: call into AER handling regardless of  severity "Luck, Tony" <tony.luck@intel.com> - 2017-08-30 01:10 +0200

csiph-web