Groups > linux.kernel > #1720945

Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown

From	Andrew Jeffery <andrew@aj.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown
Date	2017-08-28 02:10 +0200
Message-ID	<ujfMS-6Gs-7@gated-at.bofh.it> (permalink)
References	<uigrD-xp-7@gated-at.bofh.it> <uigrE-xp-29@gated-at.bofh.it> <uihnI-17Y-11@gated-at.bofh.it> <uj3C1-6Qj-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Jacek, Pavel

On Sun, 2017-08-27 at 13:01 +0200, Jacek Anaszewski wrote:
> Hi Andrew,
> 
> On 08/25/2017 09:32 AM, Pavel Machek wrote:
> > On Fri 2017-08-25 16:05:03, Andrew Jeffery wrote:
> > > In some systems, such as BMCs, we want to retain the state of LEDs
> > > across a reboot of the BMC whilst the host remains up.
> > 
> > I'd spell out what BMC is...
> 
> I agree with Pavel. Please give the expansion of the acronym
> in both DT patch and the driver commit message.

No worries, will reword and resend.

Thanks for the review.

Andrew

> 
> > 
> > Otherwise series looks good.
> > 
> > Acked-by: Pavel Machek <pavel@ucw.cz>
> 
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-08-27 13:10 +0200
  Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown Andrew Jeffery <andrew@aj.id.au> - 2017-08-28 02:10 +0200

csiph-web