Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1720799 > unrolled thread

Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown

Started byJacek Anaszewski <jacek.anaszewski@gmail.com>
First post2017-08-27 13:10 +0200
Last post2017-08-28 02:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-08-27 13:10 +0200
    Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown Andrew Jeffery <andrew@aj.id.au> - 2017-08-28 02:10 +0200

#1720799 — Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown

FromJacek Anaszewski <jacek.anaszewski@gmail.com>
Date2017-08-27 13:10 +0200
SubjectRe: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown
Message-ID<uj3C1-6Qj-1@gated-at.bofh.it>
Hi Andrew,

On 08/25/2017 09:32 AM, Pavel Machek wrote:
> On Fri 2017-08-25 16:05:03, Andrew Jeffery wrote:
>> In some systems, such as BMCs, we want to retain the state of LEDs
>> across a reboot of the BMC whilst the host remains up.
> 
> I'd spell out what BMC is...

I agree with Pavel. Please give the expansion of the acronym
in both DT patch and the driver commit message.

> 
> Otherwise series looks good.
> 
> Acked-by: Pavel Machek <pavel@ucw.cz>

-- 
Best regards,
Jacek Anaszewski

[toc] | [next] | [standalone]


#1720945

FromAndrew Jeffery <andrew@aj.id.au>
Date2017-08-28 02:10 +0200
Message-ID<ujfMS-6Gs-7@gated-at.bofh.it>
In reply to#1720799

[Multipart message — attachments visible in raw view] — view raw

Hi Jacek, Pavel

On Sun, 2017-08-27 at 13:01 +0200, Jacek Anaszewski wrote:
> Hi Andrew,
> 
> On 08/25/2017 09:32 AM, Pavel Machek wrote:
> > On Fri 2017-08-25 16:05:03, Andrew Jeffery wrote:
> > > In some systems, such as BMCs, we want to retain the state of LEDs
> > > across a reboot of the BMC whilst the host remains up.
> > 
> > I'd spell out what BMC is...
> 
> I agree with Pavel. Please give the expansion of the acronym
> in both DT patch and the driver commit message.

No worries, will reword and resend.

Thanks for the review.

Andrew

> 
> > 
> > Otherwise series looks good.
> > 
> > Acked-by: Pavel Machek <pavel@ucw.cz>
> 
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web