Groups > linux.kernel > #1722040

Re: [PATCH v4 3/4] dt-bindings: PCI: rockchip: Add support for pcie wake irq

From	Brian Norris <briannorris@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 3/4] dt-bindings: PCI: rockchip: Add support for pcie wake irq
Date	2017-08-29 00:50 +0200
Message-ID	<ujB10-2TO-9@gated-at.bofh.it> (permalink)
References	<uh837-4X1-3@gated-at.bofh.it> <uh837-4X1-1@gated-at.bofh.it> <uirn4-7qw-13@gated-at.bofh.it> <uirwK-7vh-15@gated-at.bofh.it> <ujzVg-2ie-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 28, 2017 at 04:32:55PM -0500, Rob Herring wrote:
> On Fri, Aug 25, 2017 at 1:20 PM, Brian Norris <briannorris@chromium.org> wrote:
> > On Fri, Aug 25, 2017 at 01:14:39PM -0500, Rob Herring wrote:
> >> Use the wakeup source binding:
> >> Documentation/devicetree/bindings/power/wakeup-source.txt
> >
> > And I suppose this means we'd fall under this paragraph?
> >
> >     "However if the devices have dedicated interrupt as the wakeup source
> >     then they need to specify/identify the same using device specific
> >     interrupt name. In such cases only that interrupt can be used as wakeup
> >     interrupt."
> >
> > We don't expect *any* interrupt to qualify as PCI WAKE#; so we should
> > still also document the interrupt name ("wake"?) in
> > Documentation/devicetree/bindings/pci/pci.txt as Bjorn suggested, in
> > addition to using the 'wakeup-source' property documented there.
> 
> I believe the defined interrupt name is "wakeup" as example 1 shows.

That's an example, not a definition. And the definition I quoted
literally says "device specific interrupt name". The PCIe specification
calls it "WAKE#" all over the place, so I figured that's a good name to
use.

"wakeup" is also fine I suppose, as long as we document that it must be
PCIe WAKE# signal, as per the PCIe specfication.

Brian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 3/4] dt-bindings: PCI: rockchip: Add support for pcie  wake irq Rob Herring <robh@kernel.org> - 2017-08-25 20:20 +0200
  Re: [PATCH v4 3/4] dt-bindings: PCI: rockchip: Add support for pcie  wake irq Brian Norris <briannorris@chromium.org> - 2017-08-25 20:30 +0200
    Re: [PATCH v4 3/4] dt-bindings: PCI: rockchip: Add support for pcie  wake irq Rob Herring <robh@kernel.org> - 2017-08-28 23:40 +0200
      Re: [PATCH v4 3/4] dt-bindings: PCI: rockchip: Add support for pcie  wake irq Brian Norris <briannorris@chromium.org> - 2017-08-29 00:50 +0200

csiph-web