Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1720346 > unrolled thread
| Started by | Rob Herring <robh@kernel.org> |
|---|---|
| First post | 2017-08-25 20:20 +0200 |
| Last post | 2017-08-29 00:50 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v4 3/4] dt-bindings: PCI: rockchip: Add support for pcie wake irq Rob Herring <robh@kernel.org> - 2017-08-25 20:20 +0200
Re: [PATCH v4 3/4] dt-bindings: PCI: rockchip: Add support for pcie wake irq Brian Norris <briannorris@chromium.org> - 2017-08-25 20:30 +0200
Re: [PATCH v4 3/4] dt-bindings: PCI: rockchip: Add support for pcie wake irq Rob Herring <robh@kernel.org> - 2017-08-28 23:40 +0200
Re: [PATCH v4 3/4] dt-bindings: PCI: rockchip: Add support for pcie wake irq Brian Norris <briannorris@chromium.org> - 2017-08-29 00:50 +0200
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2017-08-25 20:20 +0200 |
| Subject | Re: [PATCH v4 3/4] dt-bindings: PCI: rockchip: Add support for pcie wake irq |
| Message-ID | <uirn4-7qw-13@gated-at.bofh.it> |
On Tue, Aug 22, 2017 at 11:19:33AM +0800, Jeffy Chen wrote: > Add an optional interrupt for PCIE_WAKE pin. > > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> > --- > > Changes in v4: None > Changes in v3: None > Changes in v2: None > > .../devicetree/bindings/pci/rockchip-pcie.txt | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/rockchip-pcie.txt b/Documentation/devicetree/bindings/pci/rockchip-pcie.txt > index 5678be82530d..9f6504129e80 100644 > --- a/Documentation/devicetree/bindings/pci/rockchip-pcie.txt > +++ b/Documentation/devicetree/bindings/pci/rockchip-pcie.txt > @@ -20,10 +20,13 @@ Required properties: > - msi-map: Maps a Requester ID to an MSI controller and associated > msi-specifier data. See ./pci-msi.txt > - interrupts: Three interrupt entries must be specified. > -- interrupt-names: Must include the following names > - - "sys" > - - "legacy" > - - "client" > +- interrupt-names: Include the following names > + Required: > + - "sys" > + - "legacy" > + - "client" > + Optional: > + - "wake" Use the wakeup source binding: Documentation/devicetree/bindings/power/wakeup-source.txt Rob
[toc] | [next] | [standalone]
| From | Brian Norris <briannorris@chromium.org> |
|---|---|
| Date | 2017-08-25 20:30 +0200 |
| Message-ID | <uirwK-7vh-15@gated-at.bofh.it> |
| In reply to | #1720346 |
On Fri, Aug 25, 2017 at 01:14:39PM -0500, Rob Herring wrote:
> On Tue, Aug 22, 2017 at 11:19:33AM +0800, Jeffy Chen wrote:
> > Add an optional interrupt for PCIE_WAKE pin.
> >
> > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> > ---
> >
> > Changes in v4: None
> > Changes in v3: None
> > Changes in v2: None
> >
> > .../devicetree/bindings/pci/rockchip-pcie.txt | 20 ++++++++++++--------
> > 1 file changed, 12 insertions(+), 8 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/rockchip-pcie.txt b/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
> > index 5678be82530d..9f6504129e80 100644
> > --- a/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
> > +++ b/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
> > @@ -20,10 +20,13 @@ Required properties:
> > - msi-map: Maps a Requester ID to an MSI controller and associated
> > msi-specifier data. See ./pci-msi.txt
> > - interrupts: Three interrupt entries must be specified.
> > -- interrupt-names: Must include the following names
> > - - "sys"
> > - - "legacy"
> > - - "client"
> > +- interrupt-names: Include the following names
> > + Required:
> > + - "sys"
> > + - "legacy"
> > + - "client"
> > + Optional:
> > + - "wake"
>
> Use the wakeup source binding:
> Documentation/devicetree/bindings/power/wakeup-source.txt
And I suppose this means we'd fall under this paragraph?
"However if the devices have dedicated interrupt as the wakeup source
then they need to specify/identify the same using device specific
interrupt name. In such cases only that interrupt can be used as wakeup
interrupt."
We don't expect *any* interrupt to qualify as PCI WAKE#; so we should
still also document the interrupt name ("wake"?) in
Documentation/devicetree/bindings/pci/pci.txt as Bjorn suggested, in
addition to using the 'wakeup-source' property documented there.
Brian
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2017-08-28 23:40 +0200 |
| Message-ID | <ujzVg-2ie-35@gated-at.bofh.it> |
| In reply to | #1720354 |
On Fri, Aug 25, 2017 at 1:20 PM, Brian Norris <briannorris@chromium.org> wrote:
> On Fri, Aug 25, 2017 at 01:14:39PM -0500, Rob Herring wrote:
>> On Tue, Aug 22, 2017 at 11:19:33AM +0800, Jeffy Chen wrote:
>> > Add an optional interrupt for PCIE_WAKE pin.
>> >
>> > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>> > ---
>> >
>> > Changes in v4: None
>> > Changes in v3: None
>> > Changes in v2: None
>> >
>> > .../devicetree/bindings/pci/rockchip-pcie.txt | 20 ++++++++++++--------
>> > 1 file changed, 12 insertions(+), 8 deletions(-)
>> >
>> > diff --git a/Documentation/devicetree/bindings/pci/rockchip-pcie.txt b/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
>> > index 5678be82530d..9f6504129e80 100644
>> > --- a/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
>> > +++ b/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
>> > @@ -20,10 +20,13 @@ Required properties:
>> > - msi-map: Maps a Requester ID to an MSI controller and associated
>> > msi-specifier data. See ./pci-msi.txt
>> > - interrupts: Three interrupt entries must be specified.
>> > -- interrupt-names: Must include the following names
>> > - - "sys"
>> > - - "legacy"
>> > - - "client"
>> > +- interrupt-names: Include the following names
>> > + Required:
>> > + - "sys"
>> > + - "legacy"
>> > + - "client"
>> > + Optional:
>> > + - "wake"
>>
>> Use the wakeup source binding:
>> Documentation/devicetree/bindings/power/wakeup-source.txt
>
> And I suppose this means we'd fall under this paragraph?
>
> "However if the devices have dedicated interrupt as the wakeup source
> then they need to specify/identify the same using device specific
> interrupt name. In such cases only that interrupt can be used as wakeup
> interrupt."
>
> We don't expect *any* interrupt to qualify as PCI WAKE#; so we should
> still also document the interrupt name ("wake"?) in
> Documentation/devicetree/bindings/pci/pci.txt as Bjorn suggested, in
> addition to using the 'wakeup-source' property documented there.
I believe the defined interrupt name is "wakeup" as example 1 shows.
Rob
[toc] | [prev] | [next] | [standalone]
| From | Brian Norris <briannorris@chromium.org> |
|---|---|
| Date | 2017-08-29 00:50 +0200 |
| Message-ID | <ujB10-2TO-9@gated-at.bofh.it> |
| In reply to | #1721995 |
On Mon, Aug 28, 2017 at 04:32:55PM -0500, Rob Herring wrote:
> On Fri, Aug 25, 2017 at 1:20 PM, Brian Norris <briannorris@chromium.org> wrote:
> > On Fri, Aug 25, 2017 at 01:14:39PM -0500, Rob Herring wrote:
> >> Use the wakeup source binding:
> >> Documentation/devicetree/bindings/power/wakeup-source.txt
> >
> > And I suppose this means we'd fall under this paragraph?
> >
> > "However if the devices have dedicated interrupt as the wakeup source
> > then they need to specify/identify the same using device specific
> > interrupt name. In such cases only that interrupt can be used as wakeup
> > interrupt."
> >
> > We don't expect *any* interrupt to qualify as PCI WAKE#; so we should
> > still also document the interrupt name ("wake"?) in
> > Documentation/devicetree/bindings/pci/pci.txt as Bjorn suggested, in
> > addition to using the 'wakeup-source' property documented there.
>
> I believe the defined interrupt name is "wakeup" as example 1 shows.
That's an example, not a definition. And the definition I quoted
literally says "device specific interrupt name". The PCIe specification
calls it "WAKE#" all over the place, so I figured that's a good name to
use.
"wakeup" is also fine I suppose, as long as we document that it must be
PCIe WAKE# signal, as per the PCIe specfication.
Brian
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web