Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1720172

Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest integration

From Hans de Goede <hdegoede@redhat.com>
Newsgroups linux.kernel
Subject Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest integration
Date 2017-08-25 17:10 +0200
Message-ID <uiopb-5CW-13@gated-at.bofh.it> (permalink)
References <uinWa-5dr-21@gated-at.bofh.it> <uinWb-5dr-37@gated-at.bofh.it> <uiofw-5kt-21@gated-at.bofh.it> <uiopb-5CW-3@gated-at.bofh.it> <uiopb-5CW-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi,

On 25-08-17 17:03, Christoph Hellwig wrote:
> On Fri, Aug 25, 2017 at 05:00:31PM +0200, Hans de Goede wrote:
>> I've already removed all the typedefs and camel-case outside of
>> include/uapi/linux
>>
>> The ones in include/uapi/linux are preserved to preserve API
>> compatibility with the existing VirtualBox userspace tools.
> 
> When merging new drivers we need to fix up the user abis anyway,
> we don't want to be stuck with mistakes from the past.  And the
> APIs look pretty bad, so there will be a lot work required after
> this basic cleanup anyway.

I'm afraid that the userspace API is more or less a take it
or leave it kinda deal, we can do small cleanups, but an
entire re-design is out of the question. The vboxguest code
has a long (too long) out of tree history and the same ioctl
interface is used by VirtualBox upstream on Windows, Mac OS X,
the BSDs and Solaris, so we cannot just go and break it to
out hart's content.

Regards,

Hans

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC v2 0/2] Add Virtual Box vboxguest and vboxsf guest drivers to the mainline kernel Hans de Goede <hdegoede@redhat.com> - 2017-08-25 16:40 +0200
  Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest  integration Christoph Hellwig <hch@infradead.org> - 2017-08-25 17:00 +0200
    Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest  integration Hans de Goede <hdegoede@redhat.com> - 2017-08-25 17:10 +0200
      Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest  integration Christoph Hellwig <hch@infradead.org> - 2017-08-25 17:10 +0200
        Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest  integration Christoph Hellwig <hch@infradead.org> - 2017-08-25 17:20 +0200
        Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest  integration Hans de Goede <hdegoede@redhat.com> - 2017-08-25 17:20 +0200
      Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest  integration Christoph Hellwig <hch@infradead.org> - 2017-08-25 17:10 +0200
        Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest  integration Hans de Goede <hdegoede@redhat.com> - 2017-08-25 17:10 +0200
  Re: [RFC v2 2/2] fs: Add VirtualBox guest shared folder (vboxsf)  support Christoph Hellwig <hch@infradead.org> - 2017-08-25 17:10 +0200

csiph-web