Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1720169

Re: [RFC v2 2/2] fs: Add VirtualBox guest shared folder (vboxsf) support

From Christoph Hellwig <hch@infradead.org>
Newsgroups linux.kernel
Subject Re: [RFC v2 2/2] fs: Add VirtualBox guest shared folder (vboxsf) support
Date 2017-08-25 17:10 +0200
Message-ID <uiopc-5CW-27@gated-at.bofh.it> (permalink)
References <uinWa-5dr-21@gated-at.bofh.it> <uinWa-5dr-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Please merge the files into a a lot fewer files - basically
one .c file and a header for the protocol probably is enough.

Also kill all kinds of weird tiny wrappers that just obsfucate the code,
and make sure linux-fsdevel is on Cc for your next submission.

Also don't use i_private, instead defined alloc_inode and destroy_inode
methods and use container_of.

> +/**
> + * @note Anyone wishing to make changes here might wish to take a look at
> + *  http://www.atnf.csiro.au/people/rgooch/linux/vfs.txt
> + * which seems to be the closest there is to official documentation on
> + * writing filesystem drivers for Linux.
> + */

And drop comments like this which will create a lot more confusion than
actually helping.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC v2 0/2] Add Virtual Box vboxguest and vboxsf guest drivers to the mainline kernel Hans de Goede <hdegoede@redhat.com> - 2017-08-25 16:40 +0200
  Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest  integration Christoph Hellwig <hch@infradead.org> - 2017-08-25 17:00 +0200
    Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest  integration Hans de Goede <hdegoede@redhat.com> - 2017-08-25 17:10 +0200
      Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest  integration Christoph Hellwig <hch@infradead.org> - 2017-08-25 17:10 +0200
        Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest  integration Christoph Hellwig <hch@infradead.org> - 2017-08-25 17:20 +0200
        Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest  integration Hans de Goede <hdegoede@redhat.com> - 2017-08-25 17:20 +0200
      Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest  integration Christoph Hellwig <hch@infradead.org> - 2017-08-25 17:10 +0200
        Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest  integration Hans de Goede <hdegoede@redhat.com> - 2017-08-25 17:10 +0200
  Re: [RFC v2 2/2] fs: Add VirtualBox guest shared folder (vboxsf)  support Christoph Hellwig <hch@infradead.org> - 2017-08-25 17:10 +0200

csiph-web