Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1720070
| From | Vincent Guittot <vincent.guittot@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 2/5] sched/fair: Remove unnecessary comparison with -1 |
| Date | 2017-08-25 15:50 +0200 |
| Message-ID | <uin9L-4Gg-3@gated-at.bofh.it> (permalink) |
| References | <uijSx-2Ls-1@gated-at.bofh.it> <uijSx-2Ls-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 25 August 2017 at 12:16, Brendan Jackman <brendan.jackman@arm.com> wrote:
> Since commit 83a0a96a5f26 ("sched/fair: Leverage the idle state info
> when choosing the "idlest" cpu") find_idlest_grou_cpu (formerly
> find_idlest_cpu) no longer returns -1.
>
> Signed-off-by: Brendan Jackman <brendan.jackman@arm.com>
> Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Cc: Vincent Guittot <vincent.guittot@linaro.org>
> Cc: Josef Bacik <josef@toxicpanda.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Morten Rasmussen <morten.rasmussen@arm.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---
> kernel/sched/fair.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index f6e277c65235..4ccecbf825bf 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5583,7 +5583,7 @@ static inline int find_idlest_cpu(struct sched_domain *sd, struct task_struct *p
> }
>
> new_cpu = find_idlest_group_cpu(group, p, cpu);
> - if (new_cpu == -1 || new_cpu == cpu) {
> + if (new_cpu == cpu) {
> /* Now try balancing at a lower domain level of cpu */
> sd = sd->child;
> continue;
> --
> 2.14.1
>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v2 0/5] sched/fair: Tweaks for select_task_rq_fair slowpath Brendan Jackman <brendan.jackman@arm.com> - 2017-08-25 12:20 +0200
[PATCH v2 1/5] sched/fair: Move select_task_rq_fair slow-path into its own function Brendan Jackman <brendan.jackman@arm.com> - 2017-08-25 12:20 +0200
Re: [PATCH v2 1/5] sched/fair: Move select_task_rq_fair slow-path into its own function Josef Bacik <josef@toxicpanda.com> - 2017-08-25 14:30 +0200
Re: [PATCH v2 1/5] sched/fair: Move select_task_rq_fair slow-path into its own function Vincent Guittot <vincent.guittot@linaro.org> - 2017-08-25 15:50 +0200
[PATCH v2 5/5] sched/fair: Fix use of find_idlest_group when local group is idlest. Brendan Jackman <brendan.jackman@arm.com> - 2017-08-25 12:20 +0200
Re: [PATCH v2 5/5] sched/fair: Fix use of find_idlest_group when local group is idlest. Vincent Guittot <vincent.guittot@linaro.org> - 2017-08-25 15:40 +0200
Re: [PATCH v2 5/5] sched/fair: Fix use of find_idlest_group when local group is idlest. Brendan Jackman <brendan.jackman@arm.com> - 2017-08-25 18:00 +0200
Re: [PATCH v2 5/5] sched/fair: Fix use of find_idlest_group when local group is idlest. Vincent Guittot <vincent.guittot@linaro.org> - 2017-08-28 11:00 +0200
Re: [PATCH v2 5/5] sched/fair: Fix use of find_idlest_group when local group is idlest. Vincent Guittot <vincent.guittot@linaro.org> - 2017-08-28 11:20 +0200
Re: [PATCH v2 5/5] sched/fair: Fix use of find_idlest_group when local group is idlest. Brendan Jackman <brendan.jackman@arm.com> - 2017-08-29 19:20 +0200
[PATCH v2 4/5] sched/fair: Fix use of find_idlest_group when no groups are allowed Brendan Jackman <brendan.jackman@arm.com> - 2017-08-25 12:20 +0200
Re: [PATCH v2 4/5] sched/fair: Fix use of find_idlest_group when no groups are allowed Vincent Guittot <vincent.guittot@linaro.org> - 2017-08-25 15:40 +0200
[PATCH v2 3/5] sched/fair: Fix find_idlest_group when local group is not allowed Brendan Jackman <brendan.jackman@arm.com> - 2017-08-25 12:20 +0200
Re: [PATCH v2 3/5] sched/fair: Fix find_idlest_group when local group is not allowed Vincent Guittot <vincent.guittot@linaro.org> - 2017-08-25 15:50 +0200
[PATCH v2 2/5] sched/fair: Remove unnecessary comparison with -1 Brendan Jackman <brendan.jackman@arm.com> - 2017-08-25 12:20 +0200
Re: [PATCH v2 2/5] sched/fair: Remove unnecessary comparison with -1 Josef Bacik <josef@toxicpanda.com> - 2017-08-25 14:50 +0200
Re: [PATCH v2 2/5] sched/fair: Remove unnecessary comparison with -1 Vincent Guittot <vincent.guittot@linaro.org> - 2017-08-25 15:50 +0200
csiph-web